`munmap_chunk(): invalid pointer` when uploading heat haze maps on old low-end hardware can be worked around

[illwieckz]

I reproduced it on some old low-end Intel and Broadcom hardware, but not on old low-end Nvidia, I haven't tested ATI.

Debug: Found CRN image candidate 'gfx/weapons/flamer/haze_n': gfx/weapons/flamer/haze_n.crn 
Debug: Found 128×128 CRN image 'gfx/weapons/flamer/haze_n': gfx/weapons/flamer/haze_n.crn 
Debug: Creating image gfx/weapons/flamer/haze_n (128×128, 8 mips) 
Debug: Allocating image gfx/weapons/flamer/haze_n 
Debug: Uploading image gfx/weapons/flamer/haze_n (128×128, 1 layers, 0xde1 type, 0x83f3 format) 
]munmap_chunk(): invalid pointer

There is actually two bugs in action:

1. The heathaze map should not be loaded and uploaded because r_heatHaze is disabled when the lowest preset is used.
2. Something crashes when uploading such textures.

I know that when I skip the loading of heathaze maps that workaround the bug, so I will first focus on making sure they are not loaded when asked to not be.

Then we may investigate later why the upload fails.

[slipher]

Duplicate of #1598?

[illwieckz]

Duplicate of #1598?

Maybe. At least this thread is specific to heatHaze maps and we have a workaround for that.

[illwieckz]

So yes, it is exactly the same bug, I now dedicate this thread to the workaround related to heatHaze maps.

[illwieckz]

Here is a PR implementing a workaround by not loading heatHaze maps when the feature is disabled:

• tr_shader: do not load heatHaze map when heatHaze is disabled #1737

This doesn't fix the underlying bug though…

[slipher]

Closing since the heat haze disabling optimization was merged.