Fix some bugs from address sanitizer #1639
Merged
slipher merged 3 commits intoDaemonEngine:masterfrom Apr 6, 2025
Merged
Conversation
Found by using ASan and replacing Hunk_Alloc's body with calloc(n, 1).
R_StitchPatches can replace a grid, invalidating the grid1 pointer.
VReaperV
reviewed
Apr 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The out-of-bounds light grid read one led to visibly different lighting on Nano. This map tends to read on the edges of the grid due to its very large cell size: the light grid is only 3x4x2 for the whole map.