use VectorNormalizeFast() instead of VectorNormalize() anytime the returned length isn't used

[illwieckz]

Use VectorNormalizeFast() instead of VectorNormalize() anytime the returned length isn't used.

It does the same, but with less computations since we don't need to compute the length.

[slipher]

This one causes a bug. See the dark triangle on the upper right:

[slipher]

I don't see any point to using the fast version for something that's done very infrequently and only at loading time.

[slipher]

The bug demonstrated above affects a BSP surface, so I assume it is something that happened at load time. Probably it would be better to avoid using the "fast" version for anything during load and only use it for hot paths that happen every frame.

[illwieckz]

Interesting… So VectorNormalizeFast() does something different outside of not returning the length?

[slipher]

I would expect VectorNormalizeFast to have weaker accuracy guarantees.

[illwieckz]

Ah yes we now use Q_rsqrt_fast() instead of Q_rsqrt() in it.

[illwieckz]

Interesting:

[illwieckz]

I orgot I added a faster-less-accurate rsqrt in VectorNormalizeFast() so yes we better reserve this for hot paths.