Fix service-framework selection and the growing command panel#15
Merged
Conversation
…he page Two bugs in the web configurator, reported from use. Picking a service framework did nothing. The command only emits --server when the service target is selected, which is correct — the flag is inert otherwise — but the control was rendered unconditionally, so clicking "Express" changed neither the command nor the files and looked broken. Options can already declare when they apply; nothing honored it. The web configurator now does, so a control that cannot affect the output isn't offered. That also fixes "Monorepo layout", added in 2.9.0 with a `when` that was quietly dead. The CLI wizard already guarded both by hand. The command box also grew the page. Grid items default to min-width:auto, so an unwrapped 300-character command set the column's minimum width: measured in-page, the columns went from an even 720/720 to 48/1534 with a 1582px scroll. min-width:0 lets them hold their share and lets the existing overflow-x on .cmd actually scroll. Verified in the browser: selecting the service target reveals the framework picker and Express then yields `--server express`; columns stay 720/720 whether the command is 194 or 303 characters. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both bugs from using the configurator.
Picking a service framework did nothing
Selecting Express left the command as
npx create-packkit my-package -y.The command builder only emits
--serverwhen the service target is selected, and that's correct — the flag is inert without it. The bug is that the control was rendered unconditionally, so clicking Express changed neither the command nor the files, which reads as a broken app.Options can already declare when they apply, via a
whenpredicate. Nothing honored it. The web configurator now does, so a control that can't affect the output isn't offered at all.That also fixes a second instance I'd introduced:
Monorepo layoutshipped in 2.9.0 with awhenthat was quietly dead code, so it rendered even with monorepo off. The CLI wizard already guarded both cases by hand, so it was correct throughout — the web surface was the inconsistent one.The command box grew the page
Grid items default to
min-width: auto, so an unwrapped 300-character command sets the column's minimum width..cmdalready hadoverflow-x: auto; it never got the chance to scroll.Measured in the live page, toggling the fix off and on:
min-width: 0That 48/1534 split is exactly the squeeze in the report — the form crushed, the preview enormous.
Verified in the browser
--server express --target library --target service..cmdscrolls internally.49 tests pass, including new ones asserting both
whenpredicates behave.🤖 Generated with Claude Code