Allow intersection_point_with to work with BigDecimal. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld only convert the numerator to a float if both numerator and denominator are integers.
| @@ -1,5 +1,6 @@ | |||
| require 'minitest/autorun' | |||
| require 'geometry' | |||
| require 'bigdecimal' | |||
Collaborator
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
lib/geometry/segment.rb
Outdated
| (segment.point1.y - segment.point2.y) * (segment.point1.x - point1.x); | ||
| denominator = (point2.y - point1.y) * (segment.point1.x - segment.point2.x) - | ||
| denominator = (point2.y - point1.y) * | ||
| (segment.point1.x - segment.point2.x) - |
Collaborator
There was a problem hiding this comment.
Align the operands of an expression in an assignment spanning multiple lines.
…ing multiple lines.
lib/geometry/segment.rb
Outdated
| denominator = (point2.y - point1.y) * | ||
| (segment.point1.x - segment.point2.x) - | ||
| (segment.point1.y - segment.point2.y) * | ||
| (point2.x - point1.x); |
Collaborator
There was a problem hiding this comment.
Do not use semicolons to terminate expressions.
Owner
|
@kaczowkad Perfect, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue where intersection_point_with was not working with points that were BigDecimal. The issue was a conversion to float inside of intersection_point_with.
t = numerator.to_f / denominator;This only appears necessary if both the numerator and denominator are integers. Limiting the conversion to this case allowed the BigDecimals to work.