feat(reconciliation): compare approved and observed state - #192
Open
ElliotSun wants to merge 5 commits into
Open
feat(reconciliation): compare approved and observed state#192ElliotSun wants to merge 5 commits into
ElliotSun wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the first platform-neutral reconciliation engine for M1 Production Contract Assurance.
This PR answers what differs. It does not classify drift cause or operational status; #14 owns that layer.
Identity boundary
Approved-state matching reuses the frozen M0 canonical identity implementation:
Observed assets/properties are projected onto those same governed keys using asset/property names. Platform namespace remains observation context and does not redefine governed identity. Duplicate canonical observed identities fail closed.
v1 comparison scope
Only semantics currently represented on both sides are compared:
physicalTypevs observedphysical_typeusing trim + case-insensitive textual comparison;requiredvs observednullablewhen both are boolean values.Unknown/unasserted values are not guessed.
Raw difference model
ReconciliationDifferenceuses generic typed dimensions (missing/unexpected/mismatchplus subject/path/expected/observed). These are intentionally not the stable automation reason codes; #15 maps raw differences onto the public reason-code taxonomy.ReconciliationResultcarries:Determinism / safety
Out of scope