cas-489 nba topshot setup for local dev#428
Merged
jbluks merged 8 commits intojonathan/CAS-450from Sep 6, 2022
Merged
Conversation
* temp updates * updates * update * remove comment * remove output * updates * install package * updates * update * create yup helper * remove output * create option component * updates * updates * updates * updates * update * update validation * updates * add initial state back * updates for choices * updates * remove outpu * updates * update field name to match backend field * fix strategy payload * remove output * update component * update component * remove import * add clear error * update error message * add Error message * remove error * clear error to fix dropdown styles * set focus on address
* added get_balance script for snapshot override * updated GetFlowBalance with dummyContract * set ipfs-override default to false
0xmovses
changed the title
jbluks
approved these changes
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
•tweaks
get_nba_topshot.cdcuses array method append instead of concat due to type error found in testing.•sets addresses in scripts
•adds
make topshotcommand with flow cli command and args.•updates
getNFTIdsto take in apathparameter, this method is more generalised now and is reused across NFT strats.•adds NBA contracts for deployment and local testing.
To test locally start the app with
yarn chainmake macdevthen after runmake topshotthe Service account will then have an NBA snapshot in its wallet.TODO
I need to add templates to replace the addresses on the script so this works both locally and on mainnet in staging. Small addition.