bugfix cas-168 update does not overwrite nil fields#93
Merged
Conversation
dbslone
approved these changes
Jul 1, 2022
germanurrus
approved these changes
Jul 1, 2022
Contributor
There was a problem hiding this comment.
For some reason now name is not updating:
Sending this:
{
"name": "Update Name",
"signingAddr": "0xf8d6e0586b0a20c7",
"timestamp": "1656696627669",
"compositeSignatures": [
{
"addr": "0xf8d6e0586b0a20c7",
"keyId": 0,
"signature": "f53e3ac4cf37954c4c055824d748b4cdb354ba2cc18835d2d7d9d1159a423706d24d8889e8344b48c708e3e9916131962b5f64f7f61dfd35d4661c6fbbdc61f6"
}
]
}
and response is:
{
"id":2,
"name":"sds",
"logo":"https://gateway.pinata.cloud/ipfs/QmdjLkYuDhxeJirgTiyAjJk2kw8nvjJyM8tWi7c3hAPmio",
"onlyAuthorsToSubmit":false,
"slug":"a42891b85e",
"contractName":"11",
"timestamp":"",
"compositeSignatures":null,
"creatorAddr":"0xf8d6e0586b0a20c7",
"createdAt":"2022-07-01T17:13:25.645701Z",
"cid":"QmWy3NUoteCoB1stj8fMHUSQAkLyBfEikrqWGVB2yZfsND"
}
Contributor
Author
|
checking this now |
Contributor
Author
|
fixed. can you test again @germanurrus ? |
germanurrus
approved these changes
Jul 1, 2022
Contributor
Tested again and works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the avatar, or
Logofield was being overwritten withnilon update if a value was not sent in the payload. This has been fixed by using theCOALESCEkeyword in the sqlUpdateCommunitymodels function