Skip to content

Patch 10#772

Open
Dargon789 wants to merge 5 commits intomainfrom
patch-10
Open

Patch 10#772
Dargon789 wants to merge 5 commits intomainfrom
patch-10

Conversation

@Dargon789
Copy link
Copy Markdown
Owner

@Dargon789 Dargon789 commented Dec 24, 2025

Description

Please include a brief summary of the change.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Summary by Sourcery

Remove an unused dependency from the Bitcoin adapter and record the change in changesets.

Chores:

  • Remove the unused bitcoinjs-lib dependency from the Bitcoin adapter package.
  • Add changeset entries documenting the removal of bitcoinjs-lib from the Bitcoin adapter.

@codesandbox
Copy link
Copy Markdown

codesandbox bot commented Dec 24, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
appkit-builder-gw75 Error Error Dec 24, 2025 3:11pm
appkit-dapp Error Error Dec 24, 2025 3:11pm
appkit-demo Ready Ready Preview, Comment Dec 24, 2025 3:11pm
appkit-demo-df32 Ready Ready Preview, Comment Dec 24, 2025 3:11pm
web3-game Error Error Dec 24, 2025 3:11pm

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Dec 24, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the unused bitcoinjs-lib dependency from the Bitcoin adapter package and records the change via changeset entries.

File-Level Changes

Change Details Files
Remove unused bitcoinjs-lib runtime dependency from the Bitcoin adapter.
  • Delete bitcoinjs-lib from the dependencies list in the Bitcoin adapter package manifest
  • Update pnpm-lock.yaml to reflect the removal of the bitcoinjs-lib package reference
packages/adapters/bitcoin/package.json
pnpm-lock.yaml
Document the dependency removal as patch-level changes for the Bitcoin adapter package.
  • Add a changeset entry describing the chore-level removal of bitcoinjs-lib from the Bitcoin adapter
  • Add a changeset entry clarifying that bitcoinjs-lib was an unused dependency
.changeset/rude-feet-travel.md
.changeset/strict-wombats-dress.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the @reown/appkit-adapter-bitcoin package by eliminating an unnecessary dependency. The bitcoinjs-lib library, previously listed, has been removed to streamline the project's dependency tree. Concurrently, internal documentation has been updated to accurately reflect the current set of libraries used for Bitcoin integration, ensuring consistency and clarity within the monorepo.

Highlights

  • Dependency Removal: The bitcoinjs-lib dependency has been removed from the @reown/appkit-adapter-bitcoin package, as it was identified as unused.
  • Documentation Update: The monorepo documentation (.cursor/rules/appkit-monorepo.mdc) has been updated to reflect that the Bitcoin stack now utilizes wallet-standard and sats-connect, omitting bitcoinjs-lib.
  • Changelog Entries: Two new changeset files have been added to record this patch, detailing the removal of the bitcoinjs-lib dependency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Dec 24, 2025

Snyk checks have failed. 10 issues have been found so far.

Status Scanner Critical High Medium Low Total (10)
Open Source Security 1 8 1 0 10 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • You have two separate changesets targeting @reown/appkit-adapter-bitcoin for the same dependency removal; consider consolidating them into a single changeset to avoid multiple patch releases for one logical change.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- You have two separate changesets targeting `@reown/appkit-adapter-bitcoin` for the same dependency removal; consider consolidating them into a single changeset to avoid multiple patch releases for one logical change.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the unused bitcoinjs-lib dependency from the Bitcoin adapter, which is a good housekeeping change. The related documentation and package.json have been updated correctly. My only concern is the presence of two changeset files for the same change, which could lead to a duplicate entry in the changelog. I've left a comment suggesting to remove one of them.

Comment thread .changeset/strict-wombats-dress.md
@Dargon789 Dargon789 enabled auto-merge (squash) December 24, 2025 15:17
@Dargon789 Dargon789 linked an issue Jan 1, 2026 that may be closed by this pull request
@mergify mergify bot mentioned this pull request Apr 9, 2026
10 tasks
@Dargon789 Dargon789 disabled auto-merge April 17, 2026 22:42
@Dargon789
Copy link
Copy Markdown
Owner Author

@copilot resolve the merge conflicts in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[vc]: # wallet clean up (#765) #769

2 participants