fix(forge): adjust gas assertion CounterWithFallback (foundry-rs#14465 )

[Dargon789]

Motivation

Solution

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes

Summary by Sourcery

Add per-repository extra benchmark arguments support, refresh benchmark configuration/results, and adjust CI workflows accordingly.

New Features:

• Allow benchmark repository specs to include optional extra arguments that are appended to all benchmark commands for that repo.

Bug Fixes:

• Adjust the expected gas value for the CounterWithFallback deployment test fixture.

Enhancements:

• Propagate per-repository extra arguments through benchmark projects so all forge benchmark commands can be selectively customized.
• Expand and update the default benchmark repository sets and versions used in automation, including new aave-v4 coverage.
• Improve CLI and workflow documentation for how to specify benchmark repositories and extra arguments.
• Rename the Tempo CI job and split out the MPP e2e test into its own workflow.
• Enable Docker publish workflow builds with cache disabled to ensure fresh images.

CI:

• Update benchmark and core CI workflows to use a newer pinned version of the mold setup action.
• Refine benchmark workflows to use dedicated repo lists per benchmark type and support passing extra per-repo forge arguments.
• Reintroduce the MPP e2e test as a separate CI workflow with proper caching configuration while simplifying the original Tempo workflow.
• Simplify docs and release workflows by removing sccache setup where no longer needed and updating linker setup.

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[vercel]

@mablr is attempting to deploy a commit to the Foundry development Team on Vercel.

A member of the Team first needs to authorize it.

[sourcery-ai]

Reviewer's Guide

Extends the benchmarking harness and CI workflows to support per-repo extra forge arguments (e.g. skipping specific tests), refreshes benchmark data and repository/version sets, adjusts a forge gas snapshot, and makes several CI workflow cleanups including mold version bumps and isolating MPP checks into their own workflow.

Sequence diagram for parsing repo specs and running forge with extra args

sequenceDiagram
    actor Dev
    participant GithubWorkflow as Github_workflow
    participant FoundryBench as foundry_bench_binary
    participant RepoConfig as RepoConfig_from_str
    participant BenchmarkProject as BenchmarkProject
    participant Forge as forge_cli

    Dev->>GithubWorkflow: Configure REPOS env (e.g. vectorized/solady:v0.1.26 --nmc LifebuoyTest)
    GithubWorkflow->>FoundryBench: Run foundry-bench --repos "$REPOS"
    FoundryBench->>FoundryBench: Split REPOS by comma into repo_specs
    loop For each repo_spec
        FoundryBench->>RepoConfig: from_str(spec)
        RepoConfig-->>FoundryBench: RepoConfig { org, repo, rev, extra_args }
        FoundryBench->>BenchmarkProject: setup_from_repo(config)
        BenchmarkProject-->>FoundryBench: BenchmarkProject { extra_args }
        FoundryBench->>BenchmarkProject: bench_forge_test(version, runs)
        BenchmarkProject->>BenchmarkProject: cmd("forge test")
        BenchmarkProject-->>FoundryBench: "forge test --nmc LifebuoyTest"
        FoundryBench->>Forge: Execute benchmark command
        Forge-->>FoundryBench: Timing and results
    end
    FoundryBench-->>GithubWorkflow: Generate benchmark markdown files

Loading

Class diagram for updated benchmarking config and project types

classDiagram
    class RepoConfig {
        +String name
        +String org
        +String repo
        +String rev
        +Option_String extra_args
        +from_str(spec String) Result_RepoConfig
    }

    class BenchmarkProject {
        +String name
        +TempProject temp_project
        +PathBuf root_path
        +Option_String extra_args
        +setup_from_repo(config RepoConfig) Result_BenchmarkProject
        +install_npm_dependencies(root_path PathBuf) Result_Unit
        +cmd(base String) String
        +hyperfine(benchmark_name String, version String, command String, runs usize, prepare Option_String, cleanup Option_String) Result_Unit
        +bench_forge_test(version String, runs usize) Result_Unit
        +bench_forge_build_with_cache(version String, runs usize) Result_Unit
        +bench_forge_build_no_cache(version String, runs usize) Result_Unit
        +bench_forge_fuzz_test(version String, runs usize) Result_Unit
        +bench_forge_coverage(version String, runs usize) Result_Unit
        +bench_forge_isolate_test(version String, runs usize) Result_Unit
    }

    class BENCHMARK_REPOS {
        +Vec_RepoConfig repos
        +iter() Iter_RepoConfig
        +find(predicate Fn_RepoConfig_bool) Option_RepoConfig
    }

    RepoConfig "1" <-- "*" BENCHMARK_REPOS : contains
    RepoConfig "1" --> "1" BenchmarkProject : configures

    class Cli {
        +Option_Vec_String benchmarks
        +Option_Vec_String repos
    }

    Cli "1" --> "*" RepoConfig : parses_from_strings

Loading

Flow diagram for CI benchmarks with per-repo extra forge arguments

flowchart TD
    subgraph Inputs
        A_REPOS_INPUT["GitHub input.repos (optional)"]
        A_DEFAULT_TEST["env.TEST_REPOS (comma-separated specs)"]
        A_ISOLATE["env.ISOLATE_TEST_REPOS"]
        A_BUILD["env.BUILD_REPOS"]
        A_COVERAGE["env.COVERAGE_REPOS"]
    end

    subgraph Jobs
        J_test["Job forge_test_bench"]
        J_isolate["Job forge_isolate_test_bench"]
        J_build["Job forge_build_bench"]
        J_coverage["Job forge_coverage_bench"]
    end

    A_REPOS_INPUT -->|If set| J_test
    A_DEFAULT_TEST -->|If input.repos empty| J_test

    A_REPOS_INPUT -->|If set| J_isolate
    A_ISOLATE -->|If input.repos empty| J_isolate

    A_REPOS_INPUT -->|If set| J_build
    A_BUILD -->|If input.repos empty| J_build

    A_REPOS_INPUT -->|If set| J_coverage
    A_COVERAGE -->|If input.repos empty| J_coverage

    subgraph FoundryBenchCalls
        FB_test["foundry-bench --benchmarks forge_test"]
        FB_isolate["foundry-bench --benchmarks forge_isolate_test"]
        FB_build["foundry-bench --benchmarks forge_build_with_cache,forge_build_no_cache"]
        FB_coverage["foundry-bench --benchmarks forge_coverage"]
    end

    J_test -->|REPOS env| FB_test
    J_isolate -->|REPOS env| FB_isolate
    J_build -->|REPOS env| FB_build
    J_coverage -->|REPOS env| FB_coverage

    subgraph RepoSpecParsing
        P1["RepoConfig.from_str: split on whitespace into head and extra_args"]
        P2["Split head on ':' into repo_path and optional rev"]
        P3["Split repo_path into org and repo"]
        P4["Lookup defaults in BENCHMARK_REPOS or create new"]
        P5["Attach extra_args to RepoConfig and BenchmarkProject"]
    end

    FB_test --> P1
    FB_isolate --> P1
    FB_build --> P1
    FB_coverage --> P1

    P5 --> C1["BenchmarkProject.cmd(base) appends extra_args"]
    C1 --> C2["Hyperfine runs forge commands with per-repo flags"]

Loading

File-Level Changes

Change	Details	Files
Add support for per-repo extra forge CLI arguments in the benchmarking tool and wire them into benchmark commands.	Extend RepoConfig and BenchmarkProject with an optional extra_args field propagating from repo parsing to runtime execution. Update RepoConfig::from_str to parse specs of the form org/repo[:rev][ ] and inherit defaults from BENCHMARK_REPOS while allowing overrides for rev and extra_args. Introduce BenchmarkProject::cmd helper to append extra_args to base commands and update all forge-related benchmark invocations to use it. Clarify CLI help text for the --repos option to describe the new extended format and usage examples.	benches/src/lib.rs benches/src/main.rs
Refresh benchmark baselines and benchmark configuration to cover more repos and newer Foundry versions, while selectively skipping problematic tests.	Update LATEST.md with new benchmark date, repo list (including aave-v4), Foundry versions, timings across benchmarks, and system information. Redefine benchmark repo environment variables in benchmarks.yml into per-benchmark lists (TEST_REPOS, ISOLATE_TEST_REPOS, BUILD_REPOS, COVERAGE_REPOS) using the extended repo spec with per-repo --nmc filters to skip flaky/broken tests. Change benchmark workflow steps to consume the new env lists and adjust the forge_coverage step to use the COVERAGE_REPOS list instead of a single hard-coded repo.	benches/LATEST.md .github/workflows/benchmarks.yml
Tidy and restructure CI workflows, including mold action version bumps, MPP e2e isolation, and cache tweaks.	Rename the Tempo job in ci-tempo.yml from sanity-check to tempo-check and remove the inlined MPP e2e test from this workflow. Introduce a dedicated ci-mpp.yml workflow to run the MPP e2e test with sccache and rust-cache on depot runners, gated on the TEMPO_KEYS_TOML_B64 secret. Bump rui314/setup-mold action SHA to a newer version across multiple workflows and simplify docs, release, and other workflows by pruning some sccache-related setup where no longer needed. Update docker-publish to pass no-cache: true to docker/build-push-action.	.github/workflows/ci-tempo.yml .github/workflows/ci-mpp.yml .github/workflows/release.yml .github/workflows/ci.yml .github/workflows/docs.yml .github/workflows/crate-checks.yml .github/workflows/test-flaky.yml .github/workflows/test-isolate.yml .github/workflows/test.yml .github/workflows/docker-publish.yml
Adjust a forge CLI snapshot to match updated deployment gas for CounterWithFallback.	Update the expected deployment gas value for test contract CounterWithFallback in the CLI tests JSON snapshot.	crates/forge/tests/cli/cmd.rs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[gemini-code-assist]

Code Review

This pull request introduces support for per-repository extra arguments in benchmark commands, allowing users to customize forge commands (e.g., skipping specific tests). It also updates the latest benchmark results and system information. A review comment suggests refining the repository configuration parsing to ensure that default extra arguments are not unintentionally overwritten when they are not explicitly provided in the input string.

[sourcery-ai]

Hey - I've left some high level feedback:

• In RepoConfig::from_str, the error message still says Expected 'org/repo' or 'org/repo:rev' even though the parser now accepts extra args (e.g. org/repo:rev --nmc ...), so it would be clearer to update the message to reflect the full supported format.
• The four separate env lists in benchmarks.yml (TEST_REPOS, ISOLATE_TEST_REPOS, BUILD_REPOS, COVERAGE_REPOS) repeat many of the same entries; consider factoring out a shared base list or adding a brief comment near each to reduce the risk of them drifting out of sync over time.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `RepoConfig::from_str`, the error message still says `Expected 'org/repo' or 'org/repo:rev'` even though the parser now accepts extra args (e.g. `org/repo:rev --nmc ...`), so it would be clearer to update the message to reflect the full supported format.
- The four separate env lists in `benchmarks.yml` (TEST_REPOS, ISOLATE_TEST_REPOS, BUILD_REPOS, COVERAGE_REPOS) repeat many of the same entries; consider factoring out a shared base list or adding a brief comment near each to reduce the risk of them drifting out of sync over time.

Fix all in Cursor

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
next	Ready	Preview, Comment	Apr 27, 2026 11:21pm
react	Ready	Preview, Comment	Apr 27, 2026 11:21pm