Conversation
This reverts commit a181b69.
* [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts --------- Co-authored-by: pkieltyka <18831+pkieltyka@users.noreply.github.com> Co-authored-by: nachopiris <66640666+nachopiris@users.noreply.github.com> Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com> Co-authored-by: david-littlefarmer <17728576+david-littlefarmer@users.noreply.github.com>
) * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts --------- Co-authored-by: david-littlefarmer <17728576+david-littlefarmer@users.noreply.github.com> Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com> Co-authored-by: AlexanderKolberg <74478295+AlexanderKolberg@users.noreply.github.com>
Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com>
Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com>
Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com>
* feat: add auto prefixing check to account.signMessage * refactor: refactor logic to use ethers method
Co-authored-by: taylanpince <12650+taylanpince@users.noreply.github.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
Reviewer's Guide by SourceryThis pull request updates the webrpc-gen version and regenerates API clients for multiple packages. It also refactors message signing in the account package to handle already prefixed messages, removes testnet configurations for MONAD and SOMNIA networks, and updates signature validation in account tests to use Updated class diagram for AccountclassDiagram
class Account {
+signMessage(message: BytesLike, chainId: BigNumberish, cantValidateBehavior: string): Promise<string>
}
note for Account "Refactors message signing to handle already prefixed messages"
Updated class diagram for AccountSignerclassDiagram
class AccountSigner {
+signMessage(message: string | BytesLike): Promise<string>
}
note for AccountSigner "Signs a message with EIP-191 prefix"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
🎉 Snyk checks have passed. No issues have been found so far.✅ code/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Hey @Dargon789 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why the version constants are being reverted.
- It looks like you're reverting the webrpc-gen version, is this intentional?
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Dargon789
added a commit
that referenced
this pull request
Mar 13, 2025
* Revert "[AUTOMATED] Update constants.ts (0xsequence#681)" This reverts commit a181b69. * [AUTOMATED] Update files from 0xsequence/stack (0xsequence#680) * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts --------- * [AUTOMATED] Update files from 0xsequence/marketplace-api (0xsequence#682) * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts --------- * [AUTOMATED] Update: proto/clients/metadata.gen.ts (0xsequence#684) * [AUTOMATED] Update: proto/clients/relayer.gen.ts (0xsequence#685) * [AUTOMATED] Update: proto/clients/guard.gen.ts (0xsequence#686) * feat: auto prefix message with EIP191 if not prefixed (0xsequence#689) * feat: add auto prefixing check to account.signMessage * refactor: refactor logic to use ethers method * [AUTOMATED] Update: api/proto/clients/api.gen.ts (0xsequence#690) --------- Co-authored-by: 0xsequence-bot <50996415+0xsequence-bot@users.noreply.github.com> Co-authored-by: pkieltyka <18831+pkieltyka@users.noreply.github.com> Co-authored-by: nachopiris <66640666+nachopiris@users.noreply.github.com> Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com> Co-authored-by: david-littlefarmer <17728576+david-littlefarmer@users.noreply.github.com> Co-authored-by: AlexanderKolberg <74478295+AlexanderKolberg@users.noreply.github.com> Co-authored-by: Gabi <56271768+VGabriel45@users.noreply.github.com> Co-authored-by: taylanpince <12650+taylanpince@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Chores: