Ensure eslint is properly configured for all packages (0xsequence#971)#303
Merged
Dargon789 merged 3 commits intoDargon789:masterfrom Feb 24, 2026
Merged
Ensure eslint is properly configured for all packages (0xsequence#971)#303Dargon789 merged 3 commits intoDargon789:masterfrom
Dargon789 merged 3 commits intoDargon789:masterfrom
Conversation
* Updating happy-dom, vitest, prettier, and syncpack dev dependencies * Updating turbo repo * Updating lefthook * Updating rimraf * Updating @types/node * Updating dotenv * Updating nodemon and esbuild for primitives-cli
…ages/indexer (#969) * Move indexer clients to packages/services/indexer and remove old packages/indexer * Disable noUncheckedIndexedAccess for indexer package
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
|
@corbanbrook is attempting to deploy a commit to the Foundry development Team on Vercel. A member of the Team first needs to authorize it. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @Dargon789, your pull request is larger than the review limit of 150000 diff characters
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the development environment by standardizing ESLint configurations across all packages, ensuring consistent code quality and maintainability. It also brings various development dependencies up-to-date, enhancing overall project stability and leveraging newer tooling capabilities. Furthermore, several code generation artifacts were updated, and minor type safety and module import adjustments were made to align with modern TypeScript practices. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a significant step towards improving code quality and consistency by setting up ESLint across multiple packages. The changes include adding ESLint configurations, updating package scripts to include linting, and fixing a large number of linting errors. The introduction of linting in the pre-commit hook is a great practice. The code refactoring to improve type safety by replacing any with more specific types and using modern JavaScript features is commendable. I've identified a few areas for improvement, mainly concerning the new ESLint configurations and a minor bug in a test. Overall, this is a very positive and impactful change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.