Skip to content
DarkLiKally edited this page Jul 5, 2012 · 3 revisions

# Pull Requests

Know Java? See a bug? Fix it! I have really no time to fix all bugs and issues on my own, so I'm glas to see others helping me out with LyTreeHelper. I will get around fixing as much as I can, but maybe not as fast as you want.

Pull requests, however, are much easier to simply test and approve (or maybe make minor changes then approve).

Things you should keep in mind for pull requests:

I love pull requests, they're a great way for getting your ideas into the project. But however, there are a few things you should keep in mind, such as efficency, performance and backwards compatability.

If you want to submit a pull request with new features and not reported things

I probably wouldn't accept your pull request, because it is the simple fact that this feature could break some other features or conflict with other great big plugins. So you should only submit a pull request for new things, if you are sure that you can provide a not conflicting feature (Maybe, you should test it by yourself) and I don't want you to go do a bunch of work for not accepting the pull request.

If you want to submit a pull request for something that is already an issue

You should simply comment on the issue saying "Hello, i'm working on this bug/issue/request" to let the community know. I don't want that we're both working on the same thing.

Things you shouldn't submit for a pull requests:

  • Code formatting (I use a code formatter that will autoformat my code)
  • Documentation or JavaDocs (e.g. "a word is mispelled, x param is missing in javadocs")

# Documentation (Wiki)

See a bug in the wiki? No problem, you can fix it. You don't need complaining to me. Feel free to ask or inquire about any wiki page with an issue.