reports: Add psptool to hcl report #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds psptool support to HCL reports. The psptool is either run on dumped firmware if available, but users can also place firmware binaries from elsewhere in /firmware/external. This is a workaround as on some platforms flashrom does not work under stock firmware. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
Contributor
Author
|
On implementation Had to workaround this issue: Dasharo/dasharo-issues#1642
On repro cd /
if [ ! -d mockup-firmware ]; then
mkdir mockup-firmware && cd mockup-firmware
wget https://download.gigabyte.com/FileList/BIOS/mb_bios_MZ33-AR1_R05_F04.zip
unzip mb_*
cd - > /dev/null
fi
if [ ! -d /firmware/external ]; then
mkdir -p /firmware/external
cp mockup-firmware/SPI_UPD/image.bin /firmware/external/
cd - > /dev/null
fi
pwdLogs Details
External fw-bin: Details
Multiple files at Details
--Edit-- The ...which to me is fine. If |
m-iwanicki
reviewed
Oct 8, 2025
Contributor
Maybe update result based on return value instead? Save stderr to temporary file if psptool (...); then
touch logs/psptool.err.log
update_result "PSPTool" logs/psptool.err.log
mv tmp_stderrlog logs/psptool.err.log
else
mv tmp_stderrlog logs/psptool.err.log
update_result "PSPTool" logs/psptool.err.log
fi |
Contributor
|
Nvm, |
Add note that for psptool to return valid "Success" status in the HCL report, it must be fixed at sources. Current limitations that cause "UNKNOWN" status: * All warnings are directed to sterr * The tool mostly print warnings, not errors. This includes non-AMD binaries or just files full of zeros. * The tool almos allways returns sucess status code, including the situtations described above. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
Contributor
Author
|
@m-iwanicki added fixme |
m-iwanicki
requested changes
Oct 9, 2025
m-iwanicki
reviewed
Oct 9, 2025
Store default firmware dump path in a variable. This makes logical connection on which file flashroom shall create and which file is actualy used by psptool. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>
m-iwanicki
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PSPTool to HCL report and allow running it on user-supplied firmware binaries.