[DT-3880] Updates the style on the message. - #3018
Merged
Merged
Conversation
|
otchet-broad
marked this pull request as ready for review
August 13, 2026 18:02
otchet-broad
requested review from
kevinmarete and
rushtong
and
a lite review from Copilot
and removed request for
a team
August 13, 2026 18:02
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the “New Study Digest” email template styling and layout to improve readability in common email clients, while adjusting template tests to validate the new rendering behavior.
Changes:
- Refactors
new-study-digest.ftlto reuse inline CSS declarations, add a “new study count” summary line, render access types as badge-like spans, and right-align dataset counts. - Updates
NewStudyDigestMessageTestto assert the new badge rendering, new summary line (including pluralization), and dataset count alignment; adds a singular/plural test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/java/org/broadinstitute/consent/http/mail/message/NewStudyDigestMessageTest.java | Updates assertions to match the new template structure/styles and adds a singular/plural count test. |
| src/main/resources/freemarker/new-study-digest.ftl | Restyles the digest email with shared inline CSS, badge rendering for access types, a count summary line, and right-aligned dataset counts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rushtong
approved these changes
Aug 13, 2026
Comment on lines
+3
to
+8
| <#-- Email clients require inline CSS, so the shared declarations are defined once and reused. --> | ||
| <#assign bodyTextStyle="font-family: 'Montserrat', sans-serif; font-size: 16px; color: #1F3B50; line-height: 25px;"> | ||
| <#assign headerCellStyle="font-family: 'Montserrat', sans-serif; font-style: italic; font-size: 15px; color: #00609f; border-bottom: 1px solid #cccccc; padding: 5px;"> | ||
| <#assign dataCellStyle="font-family: 'Montserrat', sans-serif; color: #1F3B50; border-bottom: 1px solid #cccccc; padding: 5px; vertical-align: top;"> | ||
| <#assign linkStyle="text-decoration: none; font-family: 'Montserrat', sans-serif; color: #00609F; font-weight: 600;"> | ||
| <#assign badgeStyle="display: inline-block; padding: 1px 10px; border: 1px solid #cde1f0; border-radius: 12px; background-color: #eaf2f9; font-family: 'Montserrat', sans-serif; font-size: 13px; line-height: 20px; color: #00609F; white-space: nowrap;"> |
Contributor
There was a problem hiding this comment.
Not for this PR, but it would be really nice to have these as base/reusable styles in the header template.
kevinmarete
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-3880
Summary
Note to reviewers:
1 - Updated from original requirements and removed the redundant 'dataset/datasets' language in the cell with the counts.
2 - Test message sent and confirmed in Outlook and Gmail. PO confirmed Gmail looked good. I confirmed Outlook and Gmail as well. Screenshot below is from Gmail.
Have you read CONTRIBUTING.md lately? If not, do that first.