feat: update anvil cmg auth config to use ecm endpoint (#4694)#4696
feat: update anvil cmg auth config to use ecm endpoint (#4694)#4696
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Anvil CMG authentication configuration to use the External Credentials Manager (ECM) / RAS OAuth endpoint and bumps the @databiosphere/findable-ui dependency to a newer v49 patch release.
Changes:
- Upgrade
@databiosphere/findable-uifrom^49to^49.4.1. - Switch Anvil CMG dev
nihStatusendpoint from Firecloud Orchestration to the ECM/RAS OAuth endpoint. - Switch Anvil CMG prod
nihStatusendpoint from Firecloud Orchestration to the ECM/RAS OAuth endpoint.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| site-config/anvil-cmg/prod/authentication/constants.ts | Updates prod nihStatus service endpoint to ECM/RAS. |
| site-config/anvil-cmg/dev/authentication/constants.ts | Updates dev nihStatus service endpoint to ECM/RAS. |
| package.json | Bumps @databiosphere/findable-ui version range to ^49.4.1. |
| package-lock.json | Aligns lockfile to findable-ui@49.4.1 resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| nihStatus: | ||
| "https://firecloud-orchestration.dsde-prod.broadinstitute.org/api/nih/status", | ||
| "https://externalcreds.dsde-prod.broadinstitute.org/api/oauth/v1/ras", | ||
| profile: "https://sam.dsde-prod.broadinstitute.org/register/user/v1", |
There was a problem hiding this comment.
This PR updates anvil-cmg dev/prod nihStatus to the externalcreds RAS endpoint, but site-config/anvil-cmg/tempdev/authentication/constants.ts still hardcodes the old Firecloud Orchestration /api/nih/status URL. If tempdev is still a supported deployment target, consider updating/removing that stale endpoint to avoid confusion or accidental regressions later.
Closes #4694.
This pull request updates dependencies and modifies service endpoint URLs for authentication in both development and production configurations. The most important changes are grouped below:
Dependency update:
@databiosphere/findable-uidependency version inpackage.jsonfrom^49to^49.4.1, which may include bug fixes or new features.Service endpoint changes:
nihStatusendpoint insite-config/anvil-cmg/dev/authentication/constants.tsto use the new RAS OAuth endpoint (https://externalcreds.dsde-dev.broadinstitute.org/api/oauth/v1/ras) instead of the previous Firecloud Orchestration endpoint.nihStatusendpoint insite-config/anvil-cmg/prod/authentication/constants.tsto use the new RAS OAuth endpoint (https://externalcreds.dsde-prod.broadinstitute.org/api/oauth/v1/ras) instead of the previous Firecloud Orchestration endpoint.