Skip to content

Remove azuldownload and curldownload feature flags#4734

Merged
NoopDog merged 2 commits intomainfrom
fran/4733-download-ff
Mar 30, 2026
Merged

Remove azuldownload and curldownload feature flags#4734
NoopDog merged 2 commits intomainfrom
fran/4733-download-ff

Conversation

@frano-m
Copy link
Copy Markdown
Contributor

@frano-m frano-m commented Mar 30, 2026

Summary

  • Remove AZUL_DOWNLOAD and CURL_DOWNLOAD feature flags so download features are enabled unconditionally
  • Delete wrapper components (AzulFileDownloadVisibilityController, CurlDownloadExportMethod) that existed solely for feature gating
  • Preserve NRES consent group check for curl download (business logic, not a feature gate)

Closes #4733

Test plan

  • Verify file download column is visible by default on AnVIL files tab
  • Verify curl download export method appears on cohort and dataset export pages without needing ?curldownload flag
  • Verify curl download is still restricted to NRES datasets
  • Verify NCPI export feature flag still works independently

🤖 Generated with Claude Code

Closes #4733.

image image image image image

Remove the AZUL_DOWNLOAD and CURL_DOWNLOAD feature flags so download
features are enabled unconditionally. The NRES consent group check for
curl download is preserved as it is business logic, not a feature gate.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the AZUL_DOWNLOAD and CURL_DOWNLOAD feature flags so Azul file download and curl download functionality are enabled by default, while keeping the NRES consent-group restriction for dataset curl downloads.

Changes:

  • Deleted the Azul/curl download feature flags and removed their gating logic/components.
  • Made the Azul file download column visible by default (removed feature-flag-driven visibility controller and default-hidden state).
  • Kept curl download restricted to NRES datasets via existing consent-group checks/conditional rendering.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
site-config/anvil-cmg/dev/ui/filesEntityList.ts Removes the now-unnecessary Azul download visibility controller slot.
site-config/anvil-cmg/dev/index/filesEntityConfig.ts Stops default-hiding the Azul file download column so it appears by default.
site-config/anvil-cmg/dev/export/export.ts Replaces the curl download gated export method wrapper with the standard ExportMethod.
site-config/anvil-cmg/dev/detail/dataset/export/export.ts Replaces the curl download gated export method wrapper with the standard ExportMethod (still wrapped by NRES conditional).
pages/export/get-curl-command.tsx Removes feature-flag-based 404 gating so the page is always available.
pages/[entityListType]/[...params].tsx Removes curl feature-flag check while preserving NRES-based restriction for AnVIL dataset curl routes.
app/shared/entities.ts Removes AZUL_DOWNLOAD and CURL_DOWNLOAD from the FEATURES enum.
app/components/index.tsx Removes the Azul download “visibility controller” export alias.
app/components/Index/components/AzulFileDownload/azulFileDownload.tsx Deletes the feature-flag-based column visibility controller component.
app/components/Export/components/AnVILExplorer/CurlDownload/curlDownloadExportMethod.tsx Deletes the feature-flag-based curl export method wrapper component.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

)

The files tab now shows the download column without a feature flag,
so set emptyFirstColumn to true to account for the extra columnheader.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@NoopDog NoopDog merged commit f00fcaa into main Mar 30, 2026
3 checks passed
@frano-m frano-m deleted the fran/4733-download-ff branch March 30, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AnVIL DX] Remove azuldownload and curldownload feature flags

3 participants