feat: update curl download export text (#4735)#4736
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates export method configuration and copy, removing the buttonLabel field from export method configs/builders and refreshing the curl-download messaging (notably for open-access datasets), alongside a @databiosphere/findable-ui dependency bump.
Changes:
- Remove
buttonLabelfrom export method configs (EXPORT_METHODS) and associated view model builder return values. - Update curl download descriptions/titles for AnVIL CMG export methods and adjust related unit tests.
- Bump
@databiosphere/findable-uifrom^50.1.1to^50.4.0and perform minor import cleanup.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| site-config/anvil-cmg/dev/export/export.ts | Import reordering/cleanup for export config wiring. |
| site-config/anvil-cmg/dev/export/constants.ts | Removes buttonLabel from EXPORT_METHODS shape; keeps EXPORTS unchanged. |
| package.json | Upgrades @databiosphere/findable-ui dependency. |
| package-lock.json | Locks @databiosphere/findable-ui to 50.4.0. |
| app/viewModelBuilders/azul/hca-dcp/common/viewModelBuilders.ts | Removes buttonLabel from export method builder props; import reorder. |
| app/viewModelBuilders/azul/anvil-cmg/common/viewModelBuilders.tsx | Removes buttonLabel from export method builders; updates curl download text. |
| tests/viewModelBuilders/export.test.ts | Updates tests to stop asserting buttonLabel for export methods. |
| tests/viewModelBuilders/dataset-export.test.ts | Updates tests to stop asserting buttonLabel for dataset export methods. |
| tests/site-config/export-constants.test.ts | Updates required-key validation for EXPORT_METHODS to exclude buttonLabel. |
Comments suppressed due to low confidence (2)
app/viewModelBuilders/azul/anvil-cmg/common/viewModelBuilders.tsx:513
- The updated curl export copy implies the entire dataset is open-access ("download this dataset" / "This open-access dataset"), but this export method is only conditionally rendered when the dataset includes the NRES consent group and may still include other (non–open-access) consent groups. Please adjust the text to clearly state that the curl command covers only the open-access portion of the dataset/selected data (and keep the AWS Open Data Sponsorship Program note).
app/viewModelBuilders/azul/anvil-cmg/common/viewModelBuilders.tsx:516 - Issue #4735 also calls out adding a "View this dataset on AWS Open Data" link, but this PR only updates the description/title text. If the PR is intended to close #4735, consider adding that link (e.g., as part of the curl export method description/MDX content) or updating the PR description/issue linkage to reflect that the link addition is out of scope.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The export method cards no longer use button labels as link text. Use h3 heading locators instead, and navigate via ancestor anchor. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NoopDog
approved these changes
Mar 30, 2026
Replace generic testBulkDownloadIndexExportWorkflow with focused testBulkDownloadFileManifestWorkflow. Remove IndexExportButtons interface and ANVIL_INDEX_EXPORT_BUTTONS constant. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4735.
This pull request removes the use of the
buttonLabelproperty from export method configurations and their related view model builders, focusing instead on usingdescription,route, andtitlefor export actions. It also updates test cases accordingly and improves export descriptions, especially for open-access datasets. Additionally, the pull request upgrades the@databiosphere/findable-uidependency and makes some minor import cleanups.Removal of
buttonLabelfrom export methods and view model builders:Removed the
buttonLabelproperty from the parameters and return values of all export method builder functions inapp/viewModelBuilders/azul/anvil-cmg/common/viewModelBuilders.tsxandapp/viewModelBuilders/azul/hca-dcp/common/viewModelBuilders.tsto standardize export method configurations. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Updated all related test files by removing tests that checked for the existence or correctness of
buttonLabel, and adjusted required keys and assertions to reflect the removal. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Improvements to export descriptions:
descriptionandtitlefields for open-access dataset export options, clarifying that data transfer/storage costs are covered by the AWS Open Data Sponsorship Program and improving user guidance. [1] [2]Dependency and import updates:
@databiosphere/findable-uipackage to version^50.4.0inpackage.json.These changes simplify the export method configuration, improve the clarity of export options for users, and keep dependencies up to date.