Fix flaky anvil-catalog filter deselection test#4771
Merged
Conversation
Agent-Logs-Url: https://github.com/DataBiosphere/data-browser/sessions/4f68d6fe-5720-4897-8b51-8b219e4687d6 Co-authored-by: frano-m <18710366+frano-m@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix flakey test in anvil filters
Fix flaky anvil-catalog filter deselection test
Apr 15, 2026
frano-m
approved these changes
Apr 15, 2026
NoopDog
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "deselects filters through search bar" test was flaky because
selectFirstOptionused a positional.first()locator to assert selection state after clicking. When MUI re-sorts the filter list (selected items move position),.first()resolves to a different, unselected element — causing the assertion to fail intermittently.Changes
namedPopoverFilterItemhelper that locates a filter item in the open popover by display name (mirrors the existingnamedFilterItemfor the autocomplete popper)selectFirstOptionto usenamedPopoverFilterItemfor the post-click selection assertion instead of the stale positional locatorKnown Issues
None.