Skip to content

fix: flaky download file manifest e2e — wait for nav (#4828) #4835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoopDog merged 1 commit into from
May 14, 2026
+12 −0
Merged

fix: flaky download file manifest e2e — wait for nav (#4828) #4835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions e2e/anvil/anvil-dataset.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,13 @@ describe("Dataset", () => {
// Confirm file manifest export method is visible and click it.
await clickCard(page, TITLE_TEXT_REQUEST_FILE_MANIFEST);

// Wait for navigation to the manifest page before asserting the button —
// without this, the destination-page locator can poll an unmounted page
// for 15s and fail with "0 elements" even though the click succeeded.
await page.waitForURL((url) =>
url.pathname.endsWith(ROUTES.MANIFEST_DOWNLOAD)
);

// Confirm the file manifest page is loaded: check there is one button to request the manifest.
const buttons = page.locator(`${MUI_CLASSES.BUTTON}`, {
hasText: BUTTON_TEXT_REQUEST_LINK,
Expand Down Expand Up @@ -146,6 +153,11 @@ describe("Dataset", () => {
// Confirm Terra export method is visible and click it.
await clickCard(page, TITLE_TEXT_ANALYZE_IN_TERRA);

// Wait for navigation to the Terra page before asserting the form — same
// defence as the manifest test above; the locator can otherwise poll an
// unmounted page for 15s and fail even though the click succeeded.
await page.waitForURL((url) => url.pathname.endsWith(ROUTES.TERRA));

// Confirm the analyze in Terra page is loaded: check for form elements.
await expect(page.locator(MUI_CLASSES.FORM_CONTROL).first()).toBeVisible();
});
Expand Down
Loading