[AN-385] Move listRuntimes over to new Sam permissions model - take 2#4827
Merged
[AN-385] Move listRuntimes over to new Sam permissions model - take 2#4827
Conversation
…ons mode…" This reverts commit 9cdf0d0.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4827 +/- ##
===========================================
- Coverage 74.77% 74.59% -0.18%
===========================================
Files 166 166
Lines 14800 14609 -191
Branches 1112 1101 -11
===========================================
- Hits 11067 10898 -169
+ Misses 3733 3711 -22
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This was referenced Feb 12, 2025
Collaborator
Author
|
Testing is looking good on my BEE. Kicking the automation test again as ArgoCd has been a bit buggy today. Should be good for a final review. |
aednichols
approved these changes
Feb 20, 2025
lucymcnatt
approved these changes
Feb 20, 2025
Collaborator
lucymcnatt
left a comment
There was a problem hiding this comment.
Basic testing on BEE looked good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4823
JIRA ticket: https://broadworkbench.atlassian.net/browse/AN-385
This change was originally reverted, because it removed the ability to list deleted runtimes, which AOU RWB was making use of. See https://docs.google.com/document/d/1uivQxiSoFAyD7vpmFxes5037Dn1m0yx8VovsonylKYw/edit?tab=t.0#heading=h.mf724qma605n
Now that we confirmed that RWB can default to default settings instead of the user’s prior configurations, we can move forward with this PR again, with some added modifications to the swagger page to deprecate the
includeDeletedflag.