[AN-385] new sam disk permissions#4828
Merged
LizBaldo merged 14 commits intorevert-4823-mtalbott-revert-listRuntimesfrom Feb 19, 2025
Merged
[AN-385] new sam disk permissions#4828LizBaldo merged 14 commits intorevert-4823-mtalbott-revert-listRuntimesfrom
LizBaldo merged 14 commits intorevert-4823-mtalbott-revert-listRuntimesfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## revert-4823-mtalbott-revert-listRuntimes #4828 +/- ##
============================================================================
- Coverage 74.62% 74.57% -0.05%
============================================================================
Files 166 166
Lines 14685 14609 -76
Branches 1164 1101 -63
============================================================================
- Hits 10959 10895 -64
+ Misses 3726 3714 -12
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
4 tasks
431b9c3
into
revert-4823-mtalbott-revert-listRuntimes
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/AN-385
Summary of changes
What
includeDeletedquery parameter now that our get disk endpoint won't be able to return deleted disksWhy
revert-4823-mtalbott-revert-listRuntimes, so we should merge 4827 first.Testing these changes
What to test
Who tested and where
jenkins retestorjenkins multi-test.