Skip to content

Conversation

@adamnovak
Copy link
Member

This fixes #5256 by fixing the underlying code, fixing the test, and fixing CI to actually run the test.

Changelog Entry

To be copied to the draft changelog by merger:

  • CWL worker import works again
  • CWL worker import test (and other non-conformance CWL tests) now run on CI again

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passed tests, including the Gitlab tests, for the most recent commit in its branch.
  • Make sure the PR has been reviewed. If not, review it. If it has been reviewed and any requested changes seem to have been addressed, proceed.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

@DailyDreaming
Copy link
Member

@adamnovak Is this ready for review?

@adamnovak adamnovak requested a review from DailyDreaming April 30, 2025 19:58
@adamnovak
Copy link
Member Author

@DailyDreaming I think it's ready for review!

Copy link
Contributor

@stxue1 stxue1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we lack an import test on the WDL side, but LGTM

@stxue1 stxue1 enabled auto-merge (squash) May 18, 2025 04:28
@stxue1 stxue1 disabled auto-merge May 18, 2025 04:28
@adamnovak adamnovak merged commit bacc58d into master May 28, 2025
3 checks passed
@adamnovak adamnovak deleted the issues/5256-test-worker-import branch May 28, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_import_on_workers test is failing, but it not run by the CI

4 participants