Add deprecation warnings to GCE provisioner (#5506)#5518
Merged
Conversation
adamnovak
requested changes
May 12, 2026
Member
adamnovak
left a comment
There was a problem hiding this comment.
I figured this might result in multiple warnings in a single run, and I checked, and when I run a CWL workflow with the GCE provisioner I indeed see all three of these warnings in one run, with increasing levels of the logging system having been set up properly at each point.
(venv) [anovak@swords toil]% toil-cwl-runner --provisioner=gce '#workflow/github.com/denis-yuen/dockstore-whalesay:0.10'
The GCE provisioner is deprecated and will be removed in a future release. Please use Kubernetes-based autoscaling instead.
/Users/anovak/workspace/toil/venv/lib/python3.10/site-packages/google/api_core/_python_version_support.py:273: FutureWarning: You are using a Python version (3.10.18) which Google will stop supporting in new releases of google.api_core once it reaches its end of life (2026-10-04). Please upgrade to the latest Python version, or at least Python 3.11, to continue receiving updates for google.api_core past that date.
warnings.warn(message, FutureWarning)
Toil's GCE provisioner is deprecated and will be removed in a future release. Please use Kubernetes-based autoscaling instead.
Pulling debian:8 with docker...
INFO:cwl_utils.image_puller:Pulling debian:8 with docker...
Image successfully pulled: debian:8
INFO:cwl_utils.image_puller:Image successfully pulled: debian:8
...
[2026-05-12T17:09:35-0400] [MainThread] [W] [toil.common] Toil's GCE provisioner is deprecated and will be removed in a future release. Please use Kubernetes-based autoscaling instead.
...
The warning looks the nicest (and is most noticeable, because it gets the logging colors) at the final point, which is the one that comes from common.py. I would remove the other copies of the warning and just issue it in that one place.
Is there a good reason I don't know about that explains why we'd need it in all 3 of these places?
adamnovak
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the GCE provisioner, Toil will now emit deprecation warnings in
gceProvisioner.py,common.py, andcwltoil.pyto notify users that the GCE provisioner will be removed in a future release. Users should migrate to Kubernetes-based autoscaling.Resolves #5506
Changelog Entry
To be copied to the draft changelog by merger:
Reviewer Checklist
issues/XXXX-fix-the-thingin the Toil repo, or from an external repo.camelCasethat want to be insnake_case.docs/running/{cliOptions,cwl,wdl}.rstMerger Checklist