Skip to content

👷Fix build fail with the new event format - #3922

Closed
rgaignault wants to merge 2 commits into
mainfrom
romanG/fix-format-issue
Closed

👷Fix build fail with the new event format#3922
rgaignault wants to merge 2 commits into
mainfrom
romanG/fix-format-issue

Conversation

@rgaignault

@rgaignault rgaignault commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Motivation

Build are failing after updating the rum events format in the following pr : #3921.
This PR made the view property optional in CommonProperties to support vital events that don't require a view context. This broke TypeScript compilation because existing code assumed event.view was always defined.

Changes

Allow view.event to be undefined in some cases to fix build / typecheck

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@rgaignault
rgaignault requested a review from a team as a code owner October 21, 2025 14:58
@cit-pr-commenter

cit-pr-commenter Bot commented Oct 21, 2025

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 162.85 KiB 162.90 KiB +47 B +0.03%
Rum Recorder 19.78 KiB 19.78 KiB 0 B 0.00%
Rum Profiler 4.89 KiB 4.89 KiB 0 B 0.00%
Logs 56.54 KiB 56.54 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 119.81 KiB 119.86 KiB +47 B +0.04%
Worker 23.60 KiB 23.60 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.0039 0.0047 +20.51%
RUM - add action 0.0114 0.0144 +26.32%
RUM - add error 0.011 0.016 +45.45%
RUM - add timing 0.0025 0.0038 +52.00%
RUM - start view 0.0032 0.0043 +34.37%
RUM - start/stop session replay recording 0.0006 0.0009 +50.00%
Logs - log message 0.013 0.018 +38.46%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 24.99 KiB 26.15 KiB +1.16 KiB
RUM - add action 45.96 KiB 46.43 KiB +475 B
RUM - add timing 25.19 KiB 24.15 KiB -1.04 KiB
RUM - add error 50.82 KiB 52.18 KiB +1.36 KiB
RUM - start/stop session replay recording 24.59 KiB 23.80 KiB -806 B
RUM - start view 421.45 KiB 429.50 KiB +8.05 KiB
Logs - log message 42.71 KiB 42.28 KiB -443 B

🔗 RealWorld

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 21, 2025

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 92.63% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: aca2837 | Docs | Was this helpful? Give us feedback!

@rgaignault rgaignault changed the title 👷Fix format build fail 👷Fix build fail with the new event format Oct 21, 2025
@rgaignault
rgaignault marked this pull request as draft October 21, 2025 17:28
@rgaignault rgaignault closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant