Skip to content

✨ [RUM-17395] Add debug_ids to profiler wall-time trace for sourcemap unminification#4897

Merged
amortemousque merged 2 commits into
mainfrom
aymeric/debug-id-profiling
Jul 21, 2026
Merged

✨ [RUM-17395] Add debug_ids to profiler wall-time trace for sourcemap unminification#4897
amortemousque merged 2 commits into
mainfrom
aymeric/debug-id-profiling

Conversation

@amortemousque

@amortemousque amortemousque commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Un-minify profiler stack frames across micro frontends, same as Error/LoAF events already do via _dd.debug_ids.

Changes

wall-time.json now includes a debugIds array mapping each resource index to its debug ID:

{
  "resources": ["https://service-a.js", "https://service-b.js"],
  "debugIds": [{ "resourceId": 0, "debugId": "5f4b4d0a-3f9a-4b86-9f53-8f7e9a5c7d21" }]
}
  • Resolved via the existing debug-ID source-code-context lookup, same as Error/LoAF events.

Test instructions

yarn test:unit --spec "packages/browser-rum/src/domain/profiling/**/*.spec.ts"

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@amortemousque amortemousque changed the title ✨ Add debug_ids to profiler wall-time trace for sourcemap unminification ✨ [RUM-17395] Add debug_ids to profiler wall-time trace for sourcemap unminification Jul 20, 2026
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jul 20, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 71.43%
Overall Coverage: 77.23% (+0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1bddd0d | Docs | Datadog PR Page | Give us feedback!

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jul 20, 2026

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 178.53 KiB 178.61 KiB +80 B +0.04%
Rum Profiler 8.22 KiB 8.43 KiB +216 B +2.57%
Rum Recorder 21.12 KiB 21.12 KiB 0 B 0.00%
Logs 55.59 KiB 55.59 KiB 0 B 0.00%
Rum Slim 136.60 KiB 136.60 KiB 0 B 0.00%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%

@amortemousque
amortemousque force-pushed the aymeric/debug-id-profiling branch from 3ab72ae to 8c90f92 Compare July 20, 2026 07:58
@amortemousque
amortemousque marked this pull request as ready for review July 20, 2026 08:35
@amortemousque
amortemousque requested a review from a team as a code owner July 20, 2026 08:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c90f92307

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/browser-rum/src/domain/profiling/profilerDebugIds.ts Outdated
@amortemousque
amortemousque force-pushed the aymeric/debug-id-profiling branch from 4bd225a to e5cf06f Compare July 20, 2026 12:40
… IDs

buildProfilerDebugIds called getSourceCodeContext per resource URL, each
triggering a full DD_SOURCE_CODE_CONTEXT scan. Use buildDebugIdByUrl to
sync once and map URL -> debugId, then resolve resource indices from it.

@bcaudan bcaudan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amortemousque
amortemousque merged commit ab6f454 into main Jul 21, 2026
31 checks passed
@amortemousque
amortemousque deleted the aymeric/debug-id-profiling branch July 21, 2026 08:04
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants