Skip to content

Conversation

@bmermet
Copy link
Contributor

@bmermet bmermet commented Mar 17, 2025

What does this PR do?

This PR aligns the installer with the changes in DataDog/dd-trace-dotnet#6766 to split the installation command of the dotnet library OCI in two. One for installation and one for instrumentation. This will make it easier in the future to make versions of the tracer that can be installed without automatically injecting into IIS apps if needed.

Motivation

More flexibility in using the dotnet library OCI.

Describe how you validated your changes

This is covered by E2E tests.

Possible Drawbacks / Trade-offs

Additional Notes

@bmermet bmermet added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/fleet labels Mar 17, 2025
@bmermet bmermet requested review from a team as code owners March 17, 2025 07:51
@github-actions github-actions bot added the medium review PR review might take time label Mar 17, 2025
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmermet
Copy link
Contributor Author

bmermet commented Mar 17, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 17, 2025

View all feedbacks in Devflow UI.
2025-03-17 13:08:59 UTC ℹ️ Start processing command /merge


2025-03-17 13:09:10 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 41m (p90).


2025-03-17 13:34:34 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 5c22778 into main Mar 17, 2025
296 checks passed
@dd-mergequeue dd-mergequeue bot deleted the bmermet/dotnet-split-instru branch March 17, 2025 13:34
@github-actions github-actions bot added this to the 7.65.0 milestone Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/fleet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants