[test/new-e2e/containers/k8s] Test check autodiscovered via etcd#35345
Merged
dd-mergequeue[bot] merged 3 commits intomainfrom Apr 2, 2025
Merged
[test/new-e2e/containers/k8s] Test check autodiscovered via etcd#35345dd-mergequeue[bot] merged 3 commits intomainfrom
dd-mergequeue[bot] merged 3 commits intomainfrom
Conversation
davidor
added
changelog/no-changelog
qa/done
davidor
force-pushed
the
davidor/contp-714-test-etcd-with-check-config
branch
from
6b99be1 to
ba93bec
Compare
Contributor
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: dda inv aws.create-vm --pipeline-id=60756673 --os-family=ubuntuNote: This applies to commit 54e4d42 |
Contributor
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
Contributor
Static quality checks ✅Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 001fae9 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | file_tree | memory utilization | +1.78 | [+1.61, +1.94] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +1.64 | [-1.22, +4.51] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.42 | [-0.04, +0.89] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.19 | [+0.12, +0.26] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.08 | [-0.03, +0.18] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | +0.08 | [-0.07, +0.22] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.05 | [-0.74, +0.84] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.02 | [-0.64, +0.69] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.02 | [-0.62, +0.66] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.02 | [-0.02, +0.06] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.01 | [-0.75, +0.78] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.01 | [-0.72, +0.75] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.03, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.28, +0.26] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.02 | [-0.85, +0.81] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.20 | [-0.97, +0.56] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.33 | [-0.50, -0.16] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.59 | [-0.67, -0.51] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_traces | memory utilization | -2.10 | [-2.48, -1.72] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -2.43 | [-3.29, -1.57] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
davidor
force-pushed
the
davidor/contp-714-test-etcd-with-check-config
branch
3 times, most recently
from
b680e7a to
f0366c9
Compare
Contributor
Static quality checks ❌Please find below the results from static quality gates Error
Gate failure full details
Static quality gates prevent the PR to merge! You can check the static quality gates confluence page for guidance. We also have a toolbox page available to list tools useful to debug the size increase. Successful checksInfo
|
davidor
force-pushed
the
davidor/contp-714-test-etcd-with-check-config
branch
4 times, most recently
from
149b7c2 to
eb31e49
Compare
davidor
force-pushed
the
davidor/contp-714-test-etcd-with-check-config
branch
from
eb31e49 to
87b115e
Compare
CelianR
approved these changes
Apr 1, 2025
gabedos
approved these changes
Apr 1, 2025
L3n41c
approved these changes
Apr 1, 2025
Member
Author
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
|
dd-mergequeue
bot
deleted the
davidor/contp-714-test-etcd-with-check-config
branch
ogaca-dd
pushed a commit
that referenced
this pull request
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an integration test for a check autodiscovered via etcd.
This test relies on the setup introduced in DataDog/test-infra-definitions#1483, which provisions an etcd database, stores a basic OpenMetrics check configuration, and configures the Agent to use etcd as an Autodiscovery configuration provider.
Describe how you validated your changes
The test should pass