Skip to content

Comments

[Backport 7.65.x] Fix Installer Experiment: merged MSI + Agent#35359

Merged
sabrina-datadog merged 1 commit into7.65.xfrom
backport-35327-to-7.65.x
Mar 21, 2025
Merged

[Backport 7.65.x] Fix Installer Experiment: merged MSI + Agent#35359
sabrina-datadog merged 1 commit into7.65.xfrom
backport-35327-to-7.65.x

Conversation

@agent-platform-auto-pr
Copy link
Contributor

Backport 85ed8bb from #35327.


<!--

  • Contributors are encouraged to read our CONTRIBUTING documentation.
  • Both Contributor and Reviewer Checklists are available at https://datadoghq.dev/datadog-agent/guidelines/contributing/#pull-requests.
  • The pull request:
    • Should only fix one issue or add one feature at a time.
    • Must update the test suite for the relevant functionality.
    • Should pass all status checks before being reviewed or merged.
  • Commit titles should be prefixed with general area of pull request's change.
  • Please fill the below sections if possible with relevant information or links.
    -->

What does this PR do?

Add special case for windows to start and installer experiment when installing the datadog-agent package.

This ensures the bootstrap workflow is executed for self upgrades.

Motivation

https://datadoghq.atlassian.net/browse/WINA-1312
This finishes the merge of datadog-agent and datadog-installer

Describe how you validated your changes

<!--
Validate your changes before merge, ensuring that:

  • Your PR is tested by static / unit / integrations / e2e tests
  • Your PR description details which e2e tests cover your changes, if any
  • The PR description contains details of how you validated your changes. If you validated changes manually and not through automated tests, add context on why automated tests did not fit your changes validation.

If you want additional validation by a second person, you can ask reviewers to do it. Describe how to set up an environment for manual tests in the PR description. Manual validation is expected to happen on every commit before merge.

Any manual validation step should then map to an automated test. Manual validation should not substitute automation, minus exceptions not supported by test tooling yet.
-->

  • Built MSI
  • Connect to staging
  • installed the pushed new staging version (7.65.0-devel.git.579.0000ac2.pipeline.59404687)
  • Made sure it upgraded correctly without any in-use files

Look at Fleet page for fleet test on internal VM.

Possible Drawbacks / Trade-offs

Additional Notes

<!--

  • Anything else we should know when reviewing?
  • Include benchmarking information here whenever possible.
  • Include info about alternatives that were considered and why the proposed
    version was chosen.
    -->

@agent-platform-auto-pr agent-platform-auto-pr bot requested review from a team as code owners March 21, 2025 14:13
@agent-platform-auto-pr agent-platform-auto-pr bot added changelog/no-changelog [deprecated] team/windows-agent qa/done QA done before merge and regressions are covered by tests backport bot short review PR is simple enough to be reviewed quickly labels Mar 21, 2025
@agent-platform-auto-pr
Copy link
Contributor Author

agent-platform-auto-pr bot commented Mar 21, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

dda inv aws.create-vm --pipeline-id=59611295 --os-family=ubuntu

Note: This applies to commit 9899393

@agent-platform-auto-pr
Copy link
Contributor Author

agent-platform-auto-pr bot commented Mar 21, 2025

Uncompressed package size comparison

Comparison with ancestor 59c87a0602587d6b02fbbcab5532699462369dfe

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.11MB ⚠️ 816.36MB 816.25MB 0.50MB
datadog-agent-x86_64-suse 0.11MB ⚠️ 816.36MB 816.25MB 0.50MB
datadog-agent-amd64-deb 0.08MB ⚠️ 806.52MB 806.44MB 0.50MB
datadog-heroku-agent-amd64-deb 0.08MB ⚠️ 441.96MB 441.88MB 0.50MB
datadog-agent-aarch64-rpm 0.06MB ⚠️ 807.35MB 807.29MB 0.50MB
datadog-agent-arm64-deb 0.03MB ⚠️ 797.53MB 797.51MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.43MB 39.43MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.43MB 39.43MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 61.06MB 61.06MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 61.06MB 61.06MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 58.35MB 58.35MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.35MB 39.35MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.88MB 37.88MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 60.99MB 60.99MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 58.28MB 58.28MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor Author

agent-platform-auto-pr bot commented Mar 21, 2025

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 780.78 MiB 801.8 MiB 190.56 MiB 202.62 MiB
static_quality_gate_agent_deb_arm64 772.16 MiB 793.14 MiB 172.7 MiB 184.51 MiB
static_quality_gate_agent_rpm_amd64 780.83 MiB 801.79 MiB 193.16 MiB 205.03 MiB
static_quality_gate_agent_rpm_arm64 772.19 MiB 793.09 MiB 174.16 MiB 186.44 MiB
static_quality_gate_agent_suse_amd64 780.81 MiB 801.81 MiB 193.16 MiB 205.03 MiB
static_quality_gate_agent_suse_arm64 772.2 MiB 793.14 MiB 174.16 MiB 186.44 MiB
static_quality_gate_dogstatsd_deb_amd64 37.61 MiB 47.67 MiB 9.75 MiB 19.78 MiB
static_quality_gate_dogstatsd_deb_arm64 36.2 MiB 46.27 MiB 8.45 MiB 18.49 MiB
static_quality_gate_dogstatsd_rpm_amd64 37.61 MiB 47.67 MiB 9.76 MiB 19.79 MiB
static_quality_gate_dogstatsd_suse_amd64 37.61 MiB 47.67 MiB 9.76 MiB 19.79 MiB
static_quality_gate_iot_agent_deb_amd64 58.24 MiB 69.0 MiB 14.71 MiB 24.8 MiB
static_quality_gate_iot_agent_deb_arm64 55.66 MiB 66.4 MiB 12.71 MiB 22.8 MiB
static_quality_gate_iot_agent_rpm_amd64 58.24 MiB 69.0 MiB 14.73 MiB 24.8 MiB
static_quality_gate_iot_agent_rpm_arm64 55.66 MiB 66.4 MiB 12.74 MiB 22.8 MiB
static_quality_gate_iot_agent_suse_amd64 58.24 MiB 69.0 MiB 14.73 MiB 24.8 MiB
static_quality_gate_docker_agent_amd64 865.35 MiB 886.12 MiB 291.19 MiB 304.21 MiB
static_quality_gate_docker_agent_arm64 880.04 MiB 900.79 MiB 277.66 MiB 290.47 MiB
static_quality_gate_docker_agent_jmx_amd64 1.04 GiB 1.06 GiB 366.31 MiB 379.33 MiB
static_quality_gate_docker_agent_jmx_arm64 1.04 GiB 1.06 GiB 348.74 MiB 361.55 MiB
static_quality_gate_docker_dogstatsd_amd64 45.75 MiB 55.78 MiB 17.25 MiB 27.28 MiB
static_quality_gate_docker_dogstatsd_arm64 44.38 MiB 54.45 MiB 16.13 MiB 26.16 MiB
static_quality_gate_docker_cluster_agent_amd64 263.03 MiB 274.78 MiB 105.64 MiB 116.28 MiB
static_quality_gate_docker_cluster_agent_arm64 278.98 MiB 290.82 MiB 100.48 MiB 111.12 MiB

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Mar 21, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 456ff71d-076e-46ca-acd7-b716ba0a1fce

Baseline: 59c87a0
Comparison: 9899393
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.56 [-1.28, +4.40] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.16 [-0.31, +0.63] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.12 [-0.66, +0.91] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.05 [-0.74, +0.84] 1 Logs
quality_gate_idle_all_features memory utilization +0.03 [-0.06, +0.12] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.82, +0.83] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.63, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.69, +0.66] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.03 [-0.32, +0.26] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.04 [-0.82, +0.75] 1 Logs
file_tree memory utilization -0.11 [-0.23, +0.01] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.23 [-0.29, -0.17] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.38 [-1.15, +0.38] 1 Logs
quality_gate_idle memory utilization -0.47 [-0.53, -0.40] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.67 [-0.78, -0.56] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.52 [-2.33, -0.70] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@jack0x2
Copy link
Contributor

jack0x2 commented Mar 21, 2025

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Mar 21, 2025

View all feedbacks in Devflow UI.
2025-03-21 16:07:05 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on


2025-03-21 16:07:57 UTC ℹ️ Gitlab pipeline started

Started pipeline #59611295

@sabrina-datadog sabrina-datadog merged commit c419e5f into 7.65.x Mar 21, 2025
576 checks passed
@sabrina-datadog sabrina-datadog deleted the backport-35327-to-7.65.x branch March 21, 2025 19:54
@github-actions github-actions bot added this to the 7.65.0 milestone Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport bot changelog/no-changelog [deprecated] team/windows-agent qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants