Skip to content

fix: CLC metadata panic#48658

Closed
wdhif wants to merge 1 commit intomainfrom
dev/wassim.dhif/fix-clc-inventory-panic
Closed

fix: CLC metadata panic#48658
wdhif wants to merge 1 commit intomainfrom
dev/wassim.dhif/fix-clc-inventory-panic

Conversation

@wdhif
Copy link
Copy Markdown
Member

@wdhif wdhif commented Mar 31, 2026

What does this PR do?

Check config.Instances to avoid panic: runtime error: index out of range [0] with length 0.

Motivation

Fixes DataDog/helm-charts#2349

Describe how you validated your changes

CI and E2E tests.

Additional Notes

Signed-off-by: Wassim DHIF <wassim.dhif@datadoghq.com>
@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Mar 31, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 31, 2026
@dd-octo-sts dd-octo-sts bot added the team/container-platform The Container Platform Team label Mar 31, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor ce22e11e:

Results for datadog-agent_7.78.0~devel.git.728.bb9ebbb.pipeline.105211352-1_amd64.deb:

No change detected

@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ce22e11
📊 Static Quality Gates Dashboard
🔗 SQG Job
SOME SIZE DELTAS ARE N/A (ANCESTOR METRICS NOT YET AVAILABLE). RETRY JOB

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 N/A N/A → 749.066 → 750.720
agent_deb_amd64_fips N/A N/A → 707.416 → 711.230
agent_heroku_amd64 N/A N/A → 312.836 → 320.580
agent_rpm_amd64 N/A N/A → 749.050 → 750.690
agent_rpm_amd64_fips N/A N/A → 707.399 → 711.210
agent_rpm_arm64 N/A N/A → 727.500 → 732.890
agent_rpm_arm64_fips N/A N/A → 688.812 → 694.440
agent_suse_amd64 N/A N/A → 749.050 → 750.690
agent_suse_amd64_fips N/A N/A → 707.399 → 711.210
agent_suse_arm64 N/A N/A → 727.500 → 732.890
agent_suse_arm64_fips N/A N/A → 688.812 → 694.440
docker_agent_amd64 N/A N/A → 809.388 → 813.040
docker_agent_arm64 N/A N/A → 812.652 → 819.570
docker_agent_jmx_amd64 N/A N/A → 1000.304 → 1003.920
docker_agent_jmx_arm64 N/A N/A → 992.346 → 999.170
docker_cluster_agent_amd64 N/A N/A → 203.708 → 206.270
docker_cluster_agent_arm64 N/A N/A → 218.167 → 220.000
docker_cws_instrumentation_amd64 N/A N/A → 7.142 → 7.180
docker_cws_instrumentation_arm64 N/A N/A → 6.689 → 6.920
docker_dogstatsd_amd64 N/A N/A → 39.215 → 39.380
docker_dogstatsd_arm64 N/A N/A → 37.445 → 37.940
dogstatsd_deb_amd64 N/A N/A → 29.855 → 30.610
dogstatsd_deb_arm64 N/A N/A → 28.007 → 29.110
dogstatsd_rpm_amd64 N/A N/A → 29.855 → 30.610
dogstatsd_suse_amd64 N/A N/A → 29.855 → 30.610
iot_agent_deb_amd64 N/A N/A → 43.065 → 43.290
iot_agent_deb_arm64 N/A N/A → 40.128 → 40.920
iot_agent_deb_armhf N/A N/A → 40.860 → 41.030
iot_agent_rpm_amd64 N/A N/A → 43.066 → 43.290
iot_agent_suse_amd64 N/A N/A → 43.066 → 43.290
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 N/A N/A → 174.247 → 177.700
agent_deb_amd64_fips N/A N/A → 165.226 → 172.230
agent_heroku_amd64 N/A N/A → 74.904 → 79.970
agent_rpm_amd64 N/A N/A → 177.174 → 180.780
agent_rpm_amd64_fips N/A N/A → 167.243 → 173.370
agent_rpm_arm64 N/A N/A → 159.594 → 161.610
agent_rpm_arm64_fips N/A N/A → 151.271 → 155.910
agent_suse_amd64 N/A N/A → 177.174 → 180.780
agent_suse_amd64_fips N/A N/A → 167.243 → 173.370
agent_suse_arm64 N/A N/A → 159.594 → 161.610
agent_suse_arm64_fips N/A N/A → 151.271 → 155.910
docker_agent_amd64 N/A N/A → 267.218 → 271.240
docker_agent_arm64 N/A N/A → 254.503 → 259.800
docker_agent_jmx_amd64 N/A N/A → 335.876 → 339.870
docker_agent_jmx_arm64 N/A N/A → 319.142 → 324.390
docker_cluster_agent_amd64 N/A N/A → 71.297 → 72.920
docker_cluster_agent_arm64 N/A N/A → 66.935 → 68.220
docker_cws_instrumentation_amd64 N/A N/A → 2.999 → 3.330
docker_cws_instrumentation_arm64 N/A N/A → 2.729 → 3.090
docker_dogstatsd_amd64 N/A N/A → 15.160 → 15.820
docker_dogstatsd_arm64 N/A N/A → 14.483 → 14.830
dogstatsd_deb_amd64 N/A N/A → 7.885 → 8.790
dogstatsd_deb_arm64 N/A N/A → 6.773 → 7.710
dogstatsd_rpm_amd64 N/A N/A → 7.898 → 8.800
dogstatsd_suse_amd64 N/A N/A → 7.898 → 8.800
iot_agent_deb_amd64 N/A N/A → 11.351 → 12.040
iot_agent_deb_arm64 N/A N/A → 9.665 → 10.450
iot_agent_deb_armhf N/A N/A → 9.894 → 10.620
iot_agent_rpm_amd64 N/A N/A → 11.369 → 12.060
iot_agent_suse_amd64 N/A N/A → 11.369 → 12.060

@wdhif
Copy link
Copy Markdown
Member Author

wdhif commented Apr 15, 2026

Closing in favor of #49350

@wdhif wdhif closed this Apr 15, 2026
zhuminyi added a commit that referenced this pull request Apr 16, 2026
Re-submit of #49350 (reverted due to unrelated E2E test failure in
TestDDOTAutoInstalledWithEnvVar).

Add clustercheck_integration_status field to the DCA metadata payload,
reporting per-check execution status (OK/ERROR) for cluster checks
running on CLC runners.

Also fixes:
- Multi-instance reporting in clustercheck_metadata (previously only
  first instance was reported)
- config.hash uses precomputed instance IDs from ConfigWithInstanceIDs
- Rename status to dispatch_status in clustercheck_metadata
- Append [N] source index for multi-instance configs
- Fix panic on empty instances (subsumes #48658)
- Filter non-cluster checks via IsClusterCheck guard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Identify a non-fork PR short review PR is simple enough to be reviewed quickly team/container-platform The Container Platform Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Clusterchecks Metadata causes Clusteragent Panic

2 participants