Guard against non-dict Payload in is_step_function_event - #846
Open
purple4reina wants to merge 1 commit into
Open
Guard against non-dict Payload in is_step_function_event#846purple4reina wants to merge 1 commit into
purple4reina wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
Some Step Functions integrations pass a string Payload, which previously caused incorrect behavior when checking for step function event fields.
purple4reina
force-pushed
the
rey.abolofia/payload-string
branch
from
July 29, 2026 00:01
ab61bb2 to
e98bcb1
Compare
lym953
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #845
Summary
is_step_function_eventunwrappedevent.get(\"Payload\", event)and then checked for dict keys without verifying the unwrapped value was actually a dict, which broke whenPayloadwas a string.isinstance(event, dict)guard that returnsFalseearly when the payload isn't a dict.Test plan
test_is_step_function_event_payload_not_dictintests/test_trigger.pypython -m pytest tests/test_trigger.py -k IsStepFunctionEventpasses