RFC: Add headers for Ruby 2.6 to 3.1 - #29
Draft
ivoanjo wants to merge 5 commits into
Draft
Conversation
This dependency is deprecated, but at least let's use a modern version of the deprecated gem...
Member
|
Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds (trimmed) headers for Ruby 2.6 to 3.1.
Motivation:
We've been considering dropping our use of the MJIT headers, and just use the "vendored headers" approach for all Rubies. I've been using this branch to test it out.
Additional Notes:
I'm opening this as a draft as while I experiment with this approach.
How to test the change?
This PR will pair with a change on the dd-trace-rb side to use these headers.