-
Notifications
You must be signed in to change notification settings - Fork 393
feat(aws): Add scheduled invocation for retry event #1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
dd4ca38
feat(aws): Add scheduled invocation for retry event
ViBiOh c366dfe
fixup! feat(aws): Add scheduled invocation for retry event
ViBiOh ca4f033
docs(aws): Update the doc related to retry
ViBiOh b1f552e
fixup! feat(aws): Add scheduled invocation for retry event
ViBiOh 3011651
docs(aws): Reword section on store failed events
ViBiOh f2298b2
docs(aws): Adding more documentation on the retry mechanism
ViBiOh d4ee4ea
feat(aws): Ensure both storage and retry are enabled for creating sch…
ViBiOh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in which cases would we receive a
len(event) > 1AFAIK the forwarder is always triggered by a single event which could include several logsUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, but we want to launch the retry only mode in the very specific
{"retry":true}event.For example if SQS or async invocation of the lambda add this kind of entry in the received event, we'll do both the retry failed events and processing the event.
To avoid forwarding this specific event (the
{"retry":true}), we exit the function when it's the case, so I want to clearly identify this event.