Change the default value of --create-global-downtime#290
Merged
michael-richey merged 1 commit intomainfrom Oct 7, 2024
Merged
Conversation
heyronhay
approved these changes
Oct 7, 2024
Collaborator
heyronhay
left a comment
heyronhay
left a comment
There was a problem hiding this comment.
Looks like it already has logic to prevent multiple global downtimes from being created, is that correct?
Collaborator
Author
Exactly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Create a global downtime at the destination for
syncandmigratecommands by default. Allow the user to override it by setting the--create-global-downtimecommand line option toFalseDescription of the Change
This changes the default value of
--create-global-downtimetoTrue, changed the type toboolrather than a flag.Possible Drawbacks
This changes the default behavior on
sync-cli. Users could accidentally create downtimes at destinations when they don't mean to do so. This will mute all their monitors at the destination org.Release Notes
Need to bump the major release number for this change.