Skip to content

Change the default value of --create-global-downtime #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-richey merged 1 commit into from
Oct 7, 2024
Merged

Change the default value of --create-global-downtime #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions datadog_sync/commands/shared/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@ def click_config_file_provider(ctx: Context, opts: CustomOptionClass, value: Non
option(
"--create-global-downtime",
required=False,
is_flag=True,
default=False,
type=bool,
default=True,
show_default=True,
help="Scheduled downtime is meant to be removed during failover when "
"user determines monitors have enough telemetry to trigger appropriately.",
Expand Down
3 changes: 3 additions & 0 deletions tests/integration/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ def test_resource_sync(self, runner, caplog):
"--validate=false",
f"--resources={self.resource_type}",
f"--filter={self.filter}",
"--create-global-downtime=False",
]
if self.force_missing_deps:
cmd_list.append("--force-missing-dependencies")
Expand Down Expand Up @@ -128,6 +129,7 @@ def test_resource_update_sync(self, runner, caplog):
"--validate=false",
f"--resources={self.resource_type}",
f"--filter={self.filter}",
"--create-global-downtime=False",
],
)
assert 0 == ret.exit_code
Expand Down Expand Up @@ -201,6 +203,7 @@ def test_resource_cleanup(self, runner, caplog):
f"--resources={self.resource_type}",
f"--filter={self.filter}",
"--cleanup=force",
"--create-global-downtime=False",
],
)

Expand Down
1 change: 1 addition & 0 deletions tests/integration/resources/test_logs_indexes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ def test_resource_cleanup(self, runner, caplog):
f"--filter={self.filter}",
"--cleanup=force",
"--verify-ddr-status=False",
"--create-global-downtime=False",
],
)
assert 0 == ret.exit_code
Expand Down
6 changes: 6 additions & 0 deletions tests/integration/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ def test_sync(self, runner, caplog):
"--validate=false",
f"--resources={self.resources}",
"--skip-failed-resource-connections=False",
"--create-global-downtime=False",
],
)
assert 0 == ret.exit_code
Expand Down Expand Up @@ -141,6 +142,7 @@ def test_without_verify_ddr_status(self, runner, caplog):
"--skip-failed-resource-connections=False",
"--verify-ddr-status=False",
"--send-metrics=False",
"--create-global-downtime=False",
],
)
assert "No match for the request" not in caplog.text
Expand Down Expand Up @@ -173,6 +175,7 @@ def test_without_verify_ddr_status(self, runner, caplog):
f"--resources={self.resources}",
"--verify-ddr-status=False",
"--send-metrics=False",
"--create-global-downtime=False",
],
)
assert "No match for the request" not in caplog.text
Expand Down Expand Up @@ -227,6 +230,7 @@ def test_cleanup(self, runner, caplog):
"--cleanup=force",
"--skip-failed-resource-connections=False",
"--send-metrics=False",
"--create-global-downtime=False",
],
)
if ret.exit_code != 0:
Expand All @@ -244,6 +248,7 @@ def test_cleanup(self, runner, caplog):
"--cleanup=force",
"--skip-failed-resource-connections=False",
"--send-metrics=False",
"--create-global-downtime=False",
],
)

Expand Down Expand Up @@ -280,6 +285,7 @@ def test_migrate(self, runner, caplog):
"--validate=false",
f"--resources={self.resources}",
"--send-metrics=False",
"--create-global-downtime=False",
],
)
assert "No match for the request" not in caplog.text
Expand Down