RUMM-233 Inject a random TraceId on top level spans#141
Merged
Conversation
github-actions
Bot
added
the
api-surface-change
mariusc83
reviewed
Feb 19, 2020
Member
There was a problem hiding this comment.
shouldn't this be added from the Builder ?
Contributor
Author
There was a problem hiding this comment.
Indeed 😕 So why are the test green ?
Member
There was a problem hiding this comment.
So why are the test green ?
Because there's another
+ private var random: Random = SecureRandom()in the Builder 🤔.
mariusc83
force-pushed
the
dd-tracing
branch
4 times, most recently
from
79ced50 to
ea29ff4
Compare
ncreated
reviewed
Feb 20, 2020
xgouchet
force-pushed
the
xgouchet/RUMM-233_traceId
branch
2 times, most recently
from
1d84d4a to
3039a09
Compare
xgouchet
force-pushed
the
xgouchet/RUMM-233_traceId
branch
from
3039a09 to
16b779a
Compare
mariusc83
approved these changes
Feb 20, 2020
Merged
3 tasks
This was referenced Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Inject a random TraceId on top level spans
Motivation
Android uses a zygote process, meaning that new instance of the same app will always have the same trace id, unless the device gets rebooted.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)