Use SecureRandom for Trace/Span ID generation, remove usage of SecureRandom.getStrongInstance

[0xnm]

What does this PR do?

This PR does the two things:

Use SecureRandom for DatadogTracing

It fixes the regression when we pulled dd-trace-java. In RUMM-233 + #141 we switched to SecureRandom, but during the latest pull of dd-trace-java we enabled its usage only for Otel, see

dd-sdk-android/features/dd-sdk-android-trace-otel/src/main/kotlin/com/datadog/android/trace/opentelemetry/OtelTracerProvider.kt

Line 103 in e293f09

.also { setTraceId128BitGenerationEnabled(it) }

and later down the call chain

dd-sdk-android/features/dd-sdk-android-trace/src/main/kotlin/com/datadog/android/trace/internal/DatadogTracerBuilderAdapter.kt

Line 87 in e293f09

setCustomIdGenerationStrategy(IdGenerationStrategy.fromName("SECURE_RANDOM", traceId128BitGenerationEnabled))

Small change in Config.java activates SecureRandom by default.

Remove SecureRandom#getInstanceStrong usage

SecureRandom#getInstanceStrong() returns the generator which calls /dev/random and if there is not enough entropy any call to generate a random number will block until there is enough entropy.

Default constructor though is using /dev/urandom which doesn't block if there is not enough entropy. This is okay for our needs to generate ID. We are not using plain Random because it is using a timestamp as a seed, so span generated on two different devices at the same instant may have same ID.

The change is aligned with iOS generator, which is using SystemRandomNumberGenerator

At least on Linux systems it also calls /dev/urandom and not /dev/random.

Review checklist (to be filled by reviewers)

• Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
• Make sure you discussed the feature or bugfix with the maintaining team in an Issue
• Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1f01c0cda9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.01%. Comparing base (e293f09) to head (ecc8f56).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3379      +/-   ##
===========================================
- Coverage    72.01%   72.01%   -0.01%     
===========================================
  Files          956      956              
  Lines        35307    35307              
  Branches      5862     5861       -1     
===========================================
- Hits         25426    25424       -2     
- Misses        8271     8277       +6     
+ Partials      1610     1606       -4     

Files with missing lines	Coverage Δ
...ain/java/com/datadog/trace/api/ConfigDefaults.java	100.00% <ø> (ø)
...va/com/datadog/trace/api/IdGenerationStrategy.java	93.33% <100.00%> (+3.33%)	⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.