Skip to content

[RUM-18012] feat: support RN 0.87 - #1368

Merged
marco-saia-datadog merged 5 commits into
developfrom
marcosaia/rums-18012/rn-87-support-alt
Aug 13, 2026
Merged

[RUM-18012] feat: support RN 0.87#1368
marco-saia-datadog merged 5 commits into
developfrom
marcosaia/rums-18012/rn-87-support-alt

Conversation

@marco-saia-datadog

Copy link
Copy Markdown
Member

What does this PR do?

Fixes build errors introduced with RN 0.87

@marco-saia-datadog
marco-saia-datadog requested a review from a team as a code owner August 12, 2026 15:18
Copilot AI lite review requested due to automatic review settings August 12, 2026 15:18
@marco-saia-datadog marco-saia-datadog changed the title [RUM-18012] [FEAT] Support RN 0.87 [RUM-18012] feat: support RN 0.87 Aug 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the React Native SDK integrations to resolve build breaks introduced by React Native 0.87, covering iOS (Fabric/new architecture) and Android (new architecture Kotlin + internal test tooling).

Changes:

  • iOS: Gate RCTParagraphComponentView / RCTConversions imports on RN 0.87+ to use the new <React/...> header paths.
  • Android (internal-testing-tools): Pin dd-sdk-android-core to 3.12.1 to ensure dependency resolution succeeds.
  • Android (new arch): Use reactContext.currentActivity in the lifecycle listener to match the old-arch implementation and avoid relying on a potentially missing currentActivity accessor.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/react-native-session-replay/ios/Sources/RCTFabricWrapper.mm Adds RN-0.87-aware imports for Fabric paragraph view/conversions headers.
packages/internal-testing-tools/android/build.gradle Pins dd-sdk-android-core dependency to an explicit version (3.12.1).
packages/core/android/src/newarch/kotlin/com/datadog/reactnative/DdSdk.kt Fixes lifecycle resume logic to read activity via reactContext.currentActivity.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sbarrio
sbarrio requested a review from cdn34dd August 13, 2026 07:07
implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
implementation project(path: ':datadog_mobile-react-native')
implementation "com.datadoghq:dd-sdk-android-core"
implementation "com.datadoghq:dd-sdk-android-core:3.12.1"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boy

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to add this file to the bump-native-dd-sdk script:

build_gradle_files=(
"packages/core/android/build.gradle"
"packages/react-native-session-replay/android/build.gradle"
"packages/react-native-webview/android/build.gradle"
"benchmarks/android/app/build.gradle"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@sbarrio sbarrio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧

Copilot AI review requested due to automatic review settings August 13, 2026 13:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 11 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 13, 2026 15:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 12 changed files in this pull request and generated no new comments.

@marco-saia-datadog
marco-saia-datadog merged commit de379d5 into develop Aug 13, 2026
12 checks passed
@marco-saia-datadog
marco-saia-datadog deleted the marcosaia/rums-18012/rn-87-support-alt branch August 13, 2026 15:55
@sbarrio sbarrio mentioned this pull request Aug 14, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants