Skip to content

fix(telemetry): nest product errors in app-started payload - #366

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
flavien.darche/fix-telemetry-product-payload
Sep 3, 2026
Merged

fix(telemetry): nest product errors in app-started payload#366
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
flavien.darche/fix-telemetry-product-payload

Conversation

@e-n-0

@e-n-0 e-n-0 commented Sep 2, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Serializes telemetry product details directly under products.<product> and keeps optional startup errors inside that product object.

The existing object-level emplace throws when an integration registers a product, preventing app-started telemetry from being sent. This unblocks integrations such as nginx-datadog from reporting their authoritative AppSec startup state.

Validation

  • cmake --build build -j4
  • ./build/test/tests (199852 assertions in 134 test cases)
  • exercised from a local NGINX worker with AppSec enabled and disabled

@pr-commenter

pr-commenter Bot commented Sep 2, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-03 16:16:59

Comparing candidate commit 9c61349 in PR branch flavien.darche/fix-telemetry-product-payload with baseline commit 83cbde0 in branch main.

Found 4 performance improvements and 1 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:BM_HexPadded_uint64/NoPadding

  • 🟩 execution_time [-1.872ns; -1.818ns] or [-3.388%; -3.289%]

scenario:BM_HexPadded_uint64/WorstCasePadding

  • 🟩 execution_time [-1.440ns; -1.381ns] or [-2.894%; -2.775%]

scenario:BM_Hex_uint64

  • 🟥 execution_time [+0.460ns; +0.501ns] or [+2.031%; +2.212%]

scenario:BM_TraceID_ParseHex/128bit

  • 🟩 execution_time [-33.854ns; -33.780ns] or [-19.876%; -19.832%]

scenario:BM_TraceID_ParseHex/64bit

  • 🟩 execution_time [-18.715ns; -18.587ns] or [-20.068%; -19.932%]

@e-n-0
e-n-0 marked this pull request as ready for review September 2, 2026 13:46
@e-n-0
e-n-0 requested review from a team as code owners September 2, 2026 13:46
@e-n-0
e-n-0 requested a review from Anilm3 September 2, 2026 13:46

@xlamorlette-datadog xlamorlette-datadog left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

Comment thread test/telemetry/test_telemetry.cpp Outdated
Comment thread test/telemetry/test_telemetry.cpp Outdated
@e-n-0
e-n-0 force-pushed the flavien.darche/fix-telemetry-product-payload branch from fcdcad9 to 6250be1 Compare September 3, 2026 15:48
@e-n-0
e-n-0 force-pushed the flavien.darche/fix-telemetry-product-payload branch from 6250be1 to 9c61349 Compare September 3, 2026 16:11
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit d7a2e2a into main Sep 3, 2026
39 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the flavien.darche/fix-telemetry-product-payload branch September 3, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants