Skip to content

Conversation

@genesor
Copy link
Member

@genesor genesor commented Mar 14, 2025

⚠️ DO NOT MERGE ⚠️

What does this PR do?

This is an experimentation of the new testing/synctest package

Before:

go test -timeout 45s -run ^TestSendRequestWithTimeout$ github.com/DataDog/dd-trace-go/v2/internal/civisibility/utils/net -v --count=1

=== RUN   TestSendRequestWithTimeout
--- PASS: TestSendRequestWithTimeout (11.71s)
PASS
ok  	github.com/DataDog/dd-trace-go/v2/internal/civisibility/utils/net	12.072s

After:

go test -timeout 45s -run ^TestSendRequestWithTimeout$ github.com/DataDog/dd-trace-go/v2/internal/civisibility/utils/net -tags=goexperiment.synctest -v --count=1

=== RUN   TestSendRequestWithTimeout
--- PASS: TestSendRequestWithTimeout (0.00s)
PASS
ok  	github.com/DataDog/dd-trace-go/v2/internal/civisibility/utils/net	0.336s

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Mar 14, 2025
@genesor genesor force-pushed the ben.db/sync-test-rd branch from 9e0010a to 01d9a15 Compare March 14, 2025 14:43
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 14, 2025

Datadog Report

Branch report: ben.db/sync-test-rd
Commit report: 30e6de7
Test service: dd-trace-go

✅ 0 Failed, 5332 Passed, 72 Skipped, 2m 49.3s Total Time

@genesor genesor force-pushed the ben.db/sync-test-rd branch 2 times, most recently from 6b043e2 to c5a8b4a Compare March 14, 2025 15:24
@genesor genesor force-pushed the ben.db/sync-test-rd branch from c5a8b4a to 7a1fe4e Compare March 14, 2025 15:25
@pr-commenter
Copy link

pr-commenter bot commented Mar 14, 2025

Benchmarks

Benchmark execution time: 2025-03-14 15:53:09

Comparing candidate commit 7a1fe4e in PR branch ben.db/sync-test-rd with baseline commit e459938 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 2 unstable metrics.

@darccio
Copy link
Member

darccio commented Nov 14, 2025

Superseded by #3907

@darccio darccio closed this Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants