Skip to content

Conversation

@mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented May 8, 2025

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

mtoffl01 and others added 30 commits April 15, 2025 16:09
…nfigsource types, fileContentsToConfig tests
…es. Plus, apply stable config check to all phase 1 env vars, except for DD_APSEC_ENABLED
@pr-commenter
Copy link

pr-commenter bot commented May 8, 2025

Benchmarks

Benchmark execution time: 2025-05-08 14:28:30

Comparing candidate commit 51437f3 in PR branch mtoff/scfg_file_limit with baseline commit 0b05149 in branch mtoff/v2-stable_cfg_1.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 0 unstable metrics.

Base automatically changed from mtoff/v2-stable_cfg_1 to main May 27, 2025 20:38
@mtoffl01 mtoffl01 closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants