-
Notifications
You must be signed in to change notification settings - Fork 320
Refactored tests to Kotlin. #10034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactored tests to Kotlin. #10034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bric3
approved these changes
Nov 26, 2025
buildSrc/src/test/kotlin/datadog/gradle/plugin/csi/CallSiteInstrumentationPluginTest.kt
Outdated
Show resolved
Hide resolved
…trumentationPluginTest.kt Review comments Co-authored-by: Brice Dutheil <brice.dutheil@gmail.com>
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~6c0e68ad68, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058047
Total [baseline] (8.681 s) : 0, 8681147
Agent [candidate] (1.053 s) : 0, 1053428
Total [candidate] (8.661 s) : 0, 8660932
section iast
Agent [baseline] (1.19 s) : 0, 1190372
Total [baseline] (9.296 s) : 0, 9296282
Agent [candidate] (1.194 s) : 0, 1194361
Total [candidate] (9.302 s) : 0, 9302205
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~6c0e68ad68, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.492 ms) : 0, 1492
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (711.379 ms) : 0, 711379
BytebuddyAgent [candidate] (708.549 ms) : 0, 708549
GlobalTracer [baseline] (250.401 ms) : 0, 250401
GlobalTracer [candidate] (249.071 ms) : 0, 249071
AppSec [baseline] (32.346 ms) : 0, 32346
AppSec [candidate] (32.101 ms) : 0, 32101
Debugger [baseline] (6.46 ms) : 0, 6460
Debugger [candidate] (6.391 ms) : 0, 6391
Remote Config [baseline] (680.368 µs) : 0, 680
Remote Config [candidate] (676.747 µs) : 0, 677
Telemetry [baseline] (14.038 ms) : 0, 14038
Telemetry [candidate] (16.245 ms) : 0, 16245
Flare Poller [baseline] (6.212 ms) : 0, 6212
Flare Poller [candidate] (4.099 ms) : 0, 4099
section iast
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (829.753 ms) : 0, 829753
BytebuddyAgent [candidate] (832.842 ms) : 0, 832842
GlobalTracer [baseline] (237.274 ms) : 0, 237274
GlobalTracer [candidate] (238.273 ms) : 0, 238273
IAST [baseline] (29.82 ms) : 0, 29820
IAST [candidate] (32.069 ms) : 0, 32069
AppSec [baseline] (31.67 ms) : 0, 31670
AppSec [candidate] (29.593 ms) : 0, 29593
Debugger [baseline] (6.093 ms) : 0, 6093
Debugger [candidate] (6.081 ms) : 0, 6081
Remote Config [baseline] (615.906 µs) : 0, 616
Remote Config [candidate] (606.875 µs) : 0, 607
Telemetry [baseline] (7.959 ms) : 0, 7959
Telemetry [candidate] (7.881 ms) : 0, 7881
Flare Poller [baseline] (10.784 ms) : 0, 10784
Flare Poller [candidate] (10.706 ms) : 0, 10706
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~6c0e68ad68, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055979
Total [baseline] (10.757 s) : 0, 10757423
Agent [candidate] (1.063 s) : 0, 1062955
Total [candidate] (10.758 s) : 0, 10758201
section appsec
Agent [baseline] (1.229 s) : 0, 1229206
Total [baseline] (10.891 s) : 0, 10891476
Agent [candidate] (1.234 s) : 0, 1233959
Total [candidate] (10.891 s) : 0, 10890731
section iast
Agent [baseline] (1.202 s) : 0, 1202418
Total [baseline] (11.104 s) : 0, 11104081
Agent [candidate] (1.203 s) : 0, 1202619
Total [candidate] (11.197 s) : 0, 11197243
section profiling
Agent [baseline] (1.197 s) : 0, 1197016
Total [baseline] (10.931 s) : 0, 10931493
Agent [candidate] (1.2 s) : 0, 1199580
Total [candidate] (10.918 s) : 0, 10918418
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~6c0e68ad68, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.493 ms) : 0, 1493
crashtracking [candidate] (1.495 ms) : 0, 1495
BytebuddyAgent [baseline] (710.188 ms) : 0, 710188
BytebuddyAgent [candidate] (714.659 ms) : 0, 714659
GlobalTracer [baseline] (249.675 ms) : 0, 249675
GlobalTracer [candidate] (251.59 ms) : 0, 251590
AppSec [baseline] (32.162 ms) : 0, 32162
AppSec [candidate] (32.546 ms) : 0, 32546
Debugger [baseline] (6.397 ms) : 0, 6397
Debugger [candidate] (6.515 ms) : 0, 6515
Remote Config [baseline] (670.598 µs) : 0, 671
Remote Config [candidate] (673.54 µs) : 0, 674
Telemetry [baseline] (16.33 ms) : 0, 16330
Telemetry [candidate] (14.02 ms) : 0, 14020
Flare Poller [baseline] (4.179 ms) : 0, 4179
Flare Poller [candidate] (6.4 ms) : 0, 6400
section appsec
crashtracking [baseline] (1.498 ms) : 0, 1498
crashtracking [candidate] (1.491 ms) : 0, 1491
BytebuddyAgent [baseline] (732.833 ms) : 0, 732833
BytebuddyAgent [candidate] (735.556 ms) : 0, 735556
GlobalTracer [baseline] (240.974 ms) : 0, 240974
GlobalTracer [candidate] (242.28 ms) : 0, 242280
IAST [baseline] (24.849 ms) : 0, 24849
IAST [candidate] (25.063 ms) : 0, 25063
AppSec [baseline] (174.842 ms) : 0, 174842
AppSec [candidate] (175.195 ms) : 0, 175195
Debugger [baseline] (6.35 ms) : 0, 6350
Debugger [candidate] (6.308 ms) : 0, 6308
Remote Config [baseline] (685.451 µs) : 0, 685
Remote Config [candidate] (686.121 µs) : 0, 686
Telemetry [baseline] (8.147 ms) : 0, 8147
Telemetry [candidate] (8.208 ms) : 0, 8208
Flare Poller [baseline] (4.0 ms) : 0, 4000
Flare Poller [candidate] (4.035 ms) : 0, 4035
section iast
crashtracking [baseline] (1.515 ms) : 0, 1515
crashtracking [candidate] (1.516 ms) : 0, 1516
BytebuddyAgent [baseline] (839.327 ms) : 0, 839327
BytebuddyAgent [candidate] (839.466 ms) : 0, 839466
GlobalTracer [baseline] (239.577 ms) : 0, 239577
GlobalTracer [candidate] (239.331 ms) : 0, 239331
IAST [baseline] (31.892 ms) : 0, 31892
IAST [candidate] (32.709 ms) : 0, 32709
AppSec [baseline] (29.69 ms) : 0, 29690
AppSec [candidate] (29.191 ms) : 0, 29191
Debugger [baseline] (6.138 ms) : 0, 6138
Debugger [candidate] (6.133 ms) : 0, 6133
Remote Config [baseline] (610.353 µs) : 0, 610
Remote Config [candidate] (611.944 µs) : 0, 612
Telemetry [baseline] (7.954 ms) : 0, 7954
Telemetry [candidate] (7.996 ms) : 0, 7996
Flare Poller [baseline] (10.781 ms) : 0, 10781
Flare Poller [candidate] (10.681 ms) : 0, 10681
section profiling
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (733.351 ms) : 0, 733351
BytebuddyAgent [candidate] (734.658 ms) : 0, 734658
GlobalTracer [baseline] (222.343 ms) : 0, 222343
GlobalTracer [candidate] (222.896 ms) : 0, 222896
AppSec [baseline] (32.003 ms) : 0, 32003
AppSec [candidate] (32.185 ms) : 0, 32185
Debugger [baseline] (8.181 ms) : 0, 8181
Debugger [candidate] (7.67 ms) : 0, 7670
Remote Config [baseline] (688.822 µs) : 0, 689
Remote Config [candidate] (692.149 µs) : 0, 692
Telemetry [baseline] (14.841 ms) : 0, 14841
Telemetry [candidate] (15.391 ms) : 0, 15391
Flare Poller [baseline] (4.172 ms) : 0, 4172
Flare Poller [candidate] (4.171 ms) : 0, 4171
ProfilingAgent [baseline] (110.794 ms) : 0, 110794
ProfilingAgent [candidate] (111.225 ms) : 0, 111225
Profiling [baseline] (111.44 ms) : 0, 111440
Profiling [candidate] (111.85 ms) : 0, 111850
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~6c0e68ad68, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.185 ms) : 1174, 1197
. : milestone, 1185,
iast (3.093 ms) : 3056, 3131
. : milestone, 3093,
iast_FULL (5.497 ms) : 5444, 5550
. : milestone, 5497,
iast_GLOBAL (3.66 ms) : 3598, 3722
. : milestone, 3660,
profiling (1.978 ms) : 1961, 1995
. : milestone, 1978,
tracing (1.811 ms) : 1796, 1825
. : milestone, 1811,
section candidate
no_agent (1.183 ms) : 1172, 1194
. : milestone, 1183,
iast (3.255 ms) : 3207, 3303
. : milestone, 3255,
iast_FULL (5.741 ms) : 5685, 5798
. : milestone, 5741,
iast_GLOBAL (3.634 ms) : 3573, 3695
. : milestone, 3634,
profiling (2.001 ms) : 1984, 2018
. : milestone, 2001,
tracing (1.794 ms) : 1779, 1810
. : milestone, 1794,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~6c0e68ad68, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section baseline
no_agent (17.163 ms) : 16994, 17331
. : milestone, 17163,
appsec (18.783 ms) : 18593, 18973
. : milestone, 18783,
code_origins (17.767 ms) : 17590, 17944
. : milestone, 17767,
iast (17.67 ms) : 17493, 17847
. : milestone, 17670,
profiling (18.665 ms) : 18478, 18853
. : milestone, 18665,
tracing (17.616 ms) : 17441, 17790
. : milestone, 17616,
section candidate
no_agent (18.237 ms) : 18047, 18426
. : milestone, 18237,
appsec (18.575 ms) : 18387, 18763
. : milestone, 18575,
code_origins (17.903 ms) : 17725, 18082
. : milestone, 17903,
iast (17.593 ms) : 17418, 17768
. : milestone, 17593,
profiling (19.446 ms) : 19246, 19646
. : milestone, 19446,
tracing (17.449 ms) : 17277, 17620
. : milestone, 17449,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~6c0e68ad68, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.648 ms) : 3432, 3863
. : milestone, 3648,
iast (2.235 ms) : 2170, 2299
. : milestone, 2235,
iast_GLOBAL (2.277 ms) : 2212, 2342
. : milestone, 2277,
profiling (2.087 ms) : 2034, 2140
. : milestone, 2087,
tracing (2.053 ms) : 2002, 2105
. : milestone, 2053,
section candidate
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (3.718 ms) : 3500, 3937
. : milestone, 3718,
iast (2.229 ms) : 2164, 2293
. : milestone, 2229,
iast_GLOBAL (2.275 ms) : 2210, 2340
. : milestone, 2275,
profiling (2.074 ms) : 2022, 2126
. : milestone, 2074,
tracing (2.072 ms) : 2021, 2124
. : milestone, 2072,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~6c0e68ad68, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section baseline
no_agent (15.729 s) : 15729000, 15729000
. : milestone, 15729000,
appsec (14.84 s) : 14840000, 14840000
. : milestone, 14840000,
iast (18.539 s) : 18539000, 18539000
. : milestone, 18539000,
iast_GLOBAL (17.922 s) : 17922000, 17922000
. : milestone, 17922000,
profiling (14.71 s) : 14710000, 14710000
. : milestone, 14710000,
tracing (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
section candidate
no_agent (15.533 s) : 15533000, 15533000
. : milestone, 15533000,
appsec (14.612 s) : 14612000, 14612000
. : milestone, 14612000,
iast (18.622 s) : 18622000, 18622000
. : milestone, 18622000,
iast_GLOBAL (17.991 s) : 17991000, 17991000
. : milestone, 17991000,
profiling (14.429 s) : 14429000, 14429000
. : milestone, 14429000,
tracing (14.706 s) : 14706000, 14706000
. : milestone, 14706000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Second step of migration our
buildSrcfolder from Groovy to Kotlin.Moved all tests in one folder
testMotivation
Kotlin is a better choice as DSL and programming language for Gradle.
Additional Notes
Our ultimate goal is to migrate whole Gradle build to Kotlin eventually.
First step: #10015