-
Notifications
You must be signed in to change notification settings - Fork 320
Fix rum injection tests #10129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix rum injection tests #10129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
approved these changes
Dec 9, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~04a5ecdbf3, baseline=1.57.0-SNAPSHOT~dd99d16cfa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1082459
Total [baseline] (8.779 s) : 0, 8778564
Agent [candidate] (1.084 s) : 0, 1084005
Total [candidate] (8.782 s) : 0, 8782033
section iast
Agent [baseline] (1.223 s) : 0, 1223182
Total [baseline] (9.494 s) : 0, 9494167
Agent [candidate] (1.226 s) : 0, 1226260
Total [candidate] (9.489 s) : 0, 9488609
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~04a5ecdbf3, baseline=1.57.0-SNAPSHOT~dd99d16cfa
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (649.925 ms) : 0, 649925
BytebuddyAgent [candidate] (650.131 ms) : 0, 650131
GlobalTracer [baseline] (282.501 ms) : 0, 282501
GlobalTracer [candidate] (283.531 ms) : 0, 283531
AppSec [baseline] (32.47 ms) : 0, 32470
AppSec [candidate] (32.433 ms) : 0, 32433
Debugger [baseline] (67.243 ms) : 0, 67243
Debugger [candidate] (67.37 ms) : 0, 67370
Remote Config [baseline] (654.697 µs) : 0, 655
Remote Config [candidate] (711.37 µs) : 0, 711
Telemetry [baseline] (9.024 ms) : 0, 9024
Telemetry [candidate] (9.139 ms) : 0, 9139
Flare Poller [baseline] (3.665 ms) : 0, 3665
Flare Poller [candidate] (3.817 ms) : 0, 3817
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (790.709 ms) : 0, 790709
BytebuddyAgent [candidate] (793.133 ms) : 0, 793133
GlobalTracer [baseline] (256.153 ms) : 0, 256153
GlobalTracer [candidate] (256.814 ms) : 0, 256814
IAST [baseline] (26.978 ms) : 0, 26978
IAST [candidate] (26.96 ms) : 0, 26960
AppSec [baseline] (35.507 ms) : 0, 35507
AppSec [candidate] (35.495 ms) : 0, 35495
Debugger [baseline] (64.674 ms) : 0, 64674
Debugger [candidate] (64.653 ms) : 0, 64653
Remote Config [baseline] (595.939 µs) : 0, 596
Remote Config [candidate] (588.466 µs) : 0, 588
Telemetry [baseline] (8.459 ms) : 0, 8459
Telemetry [candidate] (8.448 ms) : 0, 8448
Flare Poller [baseline] (3.476 ms) : 0, 3476
Flare Poller [candidate] (3.425 ms) : 0, 3425
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~04a5ecdbf3, baseline=1.57.0-SNAPSHOT~dd99d16cfa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083110
Total [baseline] (10.848 s) : 0, 10847908
Agent [candidate] (1.091 s) : 0, 1090729
Total [candidate] (10.857 s) : 0, 10856598
section appsec
Agent [baseline] (1.27 s) : 0, 1269671
Total [baseline] (11.128 s) : 0, 11127545
Agent [candidate] (1.271 s) : 0, 1270517
Total [candidate] (11.273 s) : 0, 11272812
section iast
Agent [baseline] (1.237 s) : 0, 1236508
Total [baseline] (11.317 s) : 0, 11316599
Agent [candidate] (1.226 s) : 0, 1226317
Total [candidate] (11.198 s) : 0, 11197584
section profiling
Agent [baseline] (1.216 s) : 0, 1216030
Total [baseline] (11.06 s) : 0, 11060328
Agent [candidate] (1.209 s) : 0, 1208688
Total [candidate] (11.075 s) : 0, 11074755
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~04a5ecdbf3, baseline=1.57.0-SNAPSHOT~dd99d16cfa
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (649.178 ms) : 0, 649178
BytebuddyAgent [candidate] (654.462 ms) : 0, 654462
GlobalTracer [baseline] (282.735 ms) : 0, 282735
GlobalTracer [candidate] (284.34 ms) : 0, 284340
AppSec [baseline] (32.318 ms) : 0, 32318
AppSec [candidate] (32.662 ms) : 0, 32662
Debugger [baseline] (68.611 ms) : 0, 68611
Debugger [candidate] (68.678 ms) : 0, 68678
Remote Config [baseline] (650.134 µs) : 0, 650
Remote Config [candidate] (663.881 µs) : 0, 664
Telemetry [baseline] (9.019 ms) : 0, 9019
Telemetry [candidate] (9.126 ms) : 0, 9126
Flare Poller [baseline] (3.781 ms) : 0, 3781
Flare Poller [candidate] (3.826 ms) : 0, 3826
section appsec
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (692.574 ms) : 0, 692574
BytebuddyAgent [candidate] (692.408 ms) : 0, 692408
GlobalTracer [baseline] (260.531 ms) : 0, 260531
GlobalTracer [candidate] (260.77 ms) : 0, 260770
IAST [baseline] (24.693 ms) : 0, 24693
IAST [candidate] (24.579 ms) : 0, 24579
AppSec [baseline] (175.082 ms) : 0, 175082
AppSec [candidate] (175.361 ms) : 0, 175361
Debugger [baseline] (66.395 ms) : 0, 66395
Debugger [candidate] (66.641 ms) : 0, 66641
Remote Config [baseline] (667.058 µs) : 0, 667
Remote Config [candidate] (714.004 µs) : 0, 714
Telemetry [baseline] (8.974 ms) : 0, 8974
Telemetry [candidate] (9.133 ms) : 0, 9133
Flare Poller [baseline] (3.912 ms) : 0, 3912
Flare Poller [candidate] (4.041 ms) : 0, 4041
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (799.367 ms) : 0, 799367
BytebuddyAgent [candidate] (792.061 ms) : 0, 792061
GlobalTracer [baseline] (258.68 ms) : 0, 258680
GlobalTracer [candidate] (256.477 ms) : 0, 256477
IAST [baseline] (27.276 ms) : 0, 27276
IAST [candidate] (27.002 ms) : 0, 27002
AppSec [baseline] (35.504 ms) : 0, 35504
AppSec [candidate] (35.372 ms) : 0, 35372
Debugger [baseline] (66.12 ms) : 0, 66120
Debugger [candidate] (66.171 ms) : 0, 66171
Remote Config [baseline] (582.58 µs) : 0, 583
Remote Config [candidate] (581.948 µs) : 0, 582
Telemetry [baseline] (8.557 ms) : 0, 8557
Telemetry [candidate] (8.48 ms) : 0, 8480
Flare Poller [baseline] (3.517 ms) : 0, 3517
Flare Poller [candidate] (3.497 ms) : 0, 3497
section profiling
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (708.207 ms) : 0, 708207
BytebuddyAgent [candidate] (703.132 ms) : 0, 703132
GlobalTracer [baseline] (223.744 ms) : 0, 223744
GlobalTracer [candidate] (221.902 ms) : 0, 221902
AppSec [baseline] (32.535 ms) : 0, 32535
AppSec [candidate] (32.282 ms) : 0, 32282
Debugger [baseline] (68.612 ms) : 0, 68612
Debugger [candidate] (68.565 ms) : 0, 68565
Remote Config [baseline] (624.31 µs) : 0, 624
Remote Config [candidate] (644.529 µs) : 0, 645
Telemetry [baseline] (8.945 ms) : 0, 8945
Telemetry [candidate] (9.133 ms) : 0, 9133
Flare Poller [baseline] (3.776 ms) : 0, 3776
Flare Poller [candidate] (3.819 ms) : 0, 3819
ProfilingAgent [baseline] (98.217 ms) : 0, 98217
ProfilingAgent [candidate] (98.297 ms) : 0, 98297
Profiling [baseline] (98.795 ms) : 0, 98795
Profiling [candidate] (98.874 ms) : 0, 98874
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~04a5ecdbf3, baseline=1.57.0-SNAPSHOT~dd99d16cfa
dateFormat X
axisFormat %s
section baseline
no_agent (19.711 ms) : 19510, 19912
. : milestone, 19711,
appsec (18.86 ms) : 18669, 19051
. : milestone, 18860,
code_origins (17.703 ms) : 17527, 17879
. : milestone, 17703,
iast (17.908 ms) : 17727, 18088
. : milestone, 17908,
profiling (18.644 ms) : 18458, 18831
. : milestone, 18644,
tracing (17.481 ms) : 17308, 17655
. : milestone, 17481,
section candidate
no_agent (19.296 ms) : 19101, 19491
. : milestone, 19296,
appsec (18.52 ms) : 18332, 18709
. : milestone, 18520,
code_origins (17.696 ms) : 17519, 17874
. : milestone, 17696,
iast (18.094 ms) : 17910, 18278
. : milestone, 18094,
profiling (18.818 ms) : 18628, 19008
. : milestone, 18818,
tracing (17.711 ms) : 17536, 17887
. : milestone, 17711,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~04a5ecdbf3, baseline=1.57.0-SNAPSHOT~dd99d16cfa
dateFormat X
axisFormat %s
section baseline
no_agent (1.212 ms) : 1200, 1224
. : milestone, 1212,
iast (3.152 ms) : 3111, 3192
. : milestone, 3152,
iast_FULL (5.993 ms) : 5932, 6054
. : milestone, 5993,
iast_GLOBAL (3.482 ms) : 3427, 3537
. : milestone, 3482,
profiling (2.209 ms) : 2189, 2230
. : milestone, 2209,
tracing (1.805 ms) : 1790, 1821
. : milestone, 1805,
section candidate
no_agent (1.194 ms) : 1183, 1206
. : milestone, 1194,
iast (3.173 ms) : 3128, 3218
. : milestone, 3173,
iast_FULL (5.846 ms) : 5788, 5905
. : milestone, 5846,
iast_GLOBAL (3.582 ms) : 3525, 3639
. : milestone, 3582,
profiling (2.073 ms) : 2054, 2093
. : milestone, 2073,
tracing (1.818 ms) : 1803, 1834
. : milestone, 1818,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~04a5ecdbf3, baseline=1.57.0-SNAPSHOT~dd99d16cfa
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.457 ms) : 2405, 2509
. : milestone, 2457,
iast (2.203 ms) : 2139, 2267
. : milestone, 2203,
iast_GLOBAL (2.251 ms) : 2187, 2316
. : milestone, 2251,
profiling (2.061 ms) : 2009, 2113
. : milestone, 2061,
tracing (2.047 ms) : 1996, 2098
. : milestone, 2047,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.642 ms) : 3427, 3858
. : milestone, 3642,
iast (2.214 ms) : 2150, 2279
. : milestone, 2214,
iast_GLOBAL (2.251 ms) : 2186, 2316
. : milestone, 2251,
profiling (2.057 ms) : 2005, 2109
. : milestone, 2057,
tracing (2.044 ms) : 1993, 2094
. : milestone, 2044,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~04a5ecdbf3, baseline=1.57.0-SNAPSHOT~dd99d16cfa
dateFormat X
axisFormat %s
section baseline
no_agent (14.797 s) : 14797000, 14797000
. : milestone, 14797000,
appsec (14.931 s) : 14931000, 14931000
. : milestone, 14931000,
iast (18.162 s) : 18162000, 18162000
. : milestone, 18162000,
iast_GLOBAL (18.149 s) : 18149000, 18149000
. : milestone, 18149000,
profiling (14.755 s) : 14755000, 14755000
. : milestone, 14755000,
tracing (14.686 s) : 14686000, 14686000
. : milestone, 14686000,
section candidate
no_agent (15.545 s) : 15545000, 15545000
. : milestone, 15545000,
appsec (14.684 s) : 14684000, 14684000
. : milestone, 14684000,
iast (18.637 s) : 18637000, 18637000
. : milestone, 18637000,
iast_GLOBAL (18.084 s) : 18084000, 18084000
. : milestone, 18084000,
profiling (14.659 s) : 14659000, 14659000
. : milestone, 14659000,
tracing (14.812 s) : 14812000, 14812000
. : milestone, 14812000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: rum
Realtime User Monitoring
tag: no release notes
Changes to exclude from release notes
type: bug
Bug report and fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
RumInjector is a singleton and initialised once. Testing such kind of feature dependency should hence go in a ForkedTest
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]