-
Notifications
You must be signed in to change notification settings - Fork 322
Avoid NPE on tomcat classloading instrumentation #10256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~b84b27e5da, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080742
Total [baseline] (10.909 s) : 0, 10908602
Agent [candidate] (1.094 s) : 0, 1093878
Total [candidate] (10.832 s) : 0, 10832191
section appsec
Agent [baseline] (1.27 s) : 0, 1269772
Total [baseline] (10.997 s) : 0, 10997188
Agent [candidate] (1.274 s) : 0, 1273904
Total [candidate] (11.044 s) : 0, 11044001
section iast
Agent [baseline] (1.234 s) : 0, 1233691
Total [baseline] (11.206 s) : 0, 11206319
Agent [candidate] (1.226 s) : 0, 1226148
Total [candidate] (11.104 s) : 0, 11103888
section profiling
Agent [baseline] (1.204 s) : 0, 1204060
Total [baseline] (10.911 s) : 0, 10911345
Agent [candidate] (1.203 s) : 0, 1203497
Total [candidate] (10.918 s) : 0, 10917848
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~b84b27e5da, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (648.54 ms) : 0, 648540
BytebuddyAgent [candidate] (658.167 ms) : 0, 658167
GlobalTracer [baseline] (281.953 ms) : 0, 281953
GlobalTracer [candidate] (284.46 ms) : 0, 284460
AppSec [baseline] (32.186 ms) : 0, 32186
AppSec [candidate] (32.531 ms) : 0, 32531
Debugger [baseline] (67.287 ms) : 0, 67287
Debugger [candidate] (68.501 ms) : 0, 68501
Remote Config [baseline] (636.527 µs) : 0, 637
Remote Config [candidate] (613.165 µs) : 0, 613
Telemetry [baseline] (9.023 ms) : 0, 9023
Telemetry [candidate] (8.956 ms) : 0, 8956
Flare Poller [baseline] (4.509 ms) : 0, 4509
Flare Poller [candidate] (3.757 ms) : 0, 3757
section appsec
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (692.588 ms) : 0, 692588
BytebuddyAgent [candidate] (694.957 ms) : 0, 694957
GlobalTracer [baseline] (259.745 ms) : 0, 259745
GlobalTracer [candidate] (260.091 ms) : 0, 260091
AppSec [baseline] (173.242 ms) : 0, 173242
AppSec [candidate] (174.697 ms) : 0, 174697
Debugger [baseline] (69.186 ms) : 0, 69186
Debugger [candidate] (68.839 ms) : 0, 68839
Remote Config [baseline] (697.241 µs) : 0, 697
Remote Config [candidate] (737.071 µs) : 0, 737
Telemetry [baseline] (9.107 ms) : 0, 9107
Telemetry [candidate] (9.139 ms) : 0, 9139
Flare Poller [baseline] (3.769 ms) : 0, 3769
Flare Poller [candidate] (3.903 ms) : 0, 3903
IAST [baseline] (24.652 ms) : 0, 24652
IAST [candidate] (24.71 ms) : 0, 24710
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (798.089 ms) : 0, 798089
BytebuddyAgent [candidate] (793.563 ms) : 0, 793563
GlobalTracer [baseline] (258.455 ms) : 0, 258455
GlobalTracer [candidate] (256.174 ms) : 0, 256174
AppSec [baseline] (34.459 ms) : 0, 34459
AppSec [candidate] (30.879 ms) : 0, 30879
Debugger [baseline] (65.977 ms) : 0, 65977
Debugger [candidate] (69.3 ms) : 0, 69300
Remote Config [baseline] (579.819 µs) : 0, 580
Remote Config [candidate] (603.961 µs) : 0, 604
Telemetry [baseline] (8.535 ms) : 0, 8535
Telemetry [candidate] (8.483 ms) : 0, 8483
Flare Poller [baseline] (3.512 ms) : 0, 3512
Flare Poller [candidate] (3.519 ms) : 0, 3519
IAST [baseline] (27.381 ms) : 0, 27381
IAST [candidate] (27.205 ms) : 0, 27205
section profiling
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (702.174 ms) : 0, 702174
BytebuddyAgent [candidate] (701.498 ms) : 0, 701498
GlobalTracer [baseline] (221.163 ms) : 0, 221163
GlobalTracer [candidate] (221.219 ms) : 0, 221219
AppSec [baseline] (32.105 ms) : 0, 32105
AppSec [candidate] (32.124 ms) : 0, 32124
Debugger [baseline] (67.918 ms) : 0, 67918
Debugger [candidate] (68.025 ms) : 0, 68025
Remote Config [baseline] (637.645 µs) : 0, 638
Remote Config [candidate] (627.984 µs) : 0, 628
Telemetry [baseline] (8.727 ms) : 0, 8727
Telemetry [candidate] (8.689 ms) : 0, 8689
Flare Poller [baseline] (3.686 ms) : 0, 3686
Flare Poller [candidate] (3.708 ms) : 0, 3708
ProfilingAgent [baseline] (96.766 ms) : 0, 96766
ProfilingAgent [candidate] (96.735 ms) : 0, 96735
Profiling [baseline] (97.344 ms) : 0, 97344
Profiling [candidate] (97.296 ms) : 0, 97296
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~b84b27e5da, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1098340
Total [baseline] (8.795 s) : 0, 8795182
Agent [candidate] (1.095 s) : 0, 1094574
Total [candidate] (8.75 s) : 0, 8750500
section iast
Agent [baseline] (1.229 s) : 0, 1228617
Total [baseline] (9.326 s) : 0, 9325617
Agent [candidate] (1.22 s) : 0, 1220034
Total [candidate] (9.243 s) : 0, 9242670
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~b84b27e5da, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (659.473 ms) : 0, 659473
BytebuddyAgent [candidate] (658.063 ms) : 0, 658063
GlobalTracer [baseline] (287.012 ms) : 0, 287012
GlobalTracer [candidate] (285.672 ms) : 0, 285672
AppSec [baseline] (33.115 ms) : 0, 33115
AppSec [candidate] (32.729 ms) : 0, 32729
Debugger [baseline] (68.185 ms) : 0, 68185
Debugger [candidate] (67.639 ms) : 0, 67639
Remote Config [baseline] (639.352 µs) : 0, 639
Remote Config [candidate] (626.286 µs) : 0, 626
Telemetry [baseline] (9.074 ms) : 0, 9074
Telemetry [candidate] (9.092 ms) : 0, 9092
Flare Poller [baseline] (3.811 ms) : 0, 3811
Flare Poller [candidate] (3.799 ms) : 0, 3799
section iast
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (796.971 ms) : 0, 796971
BytebuddyAgent [candidate] (789.451 ms) : 0, 789451
GlobalTracer [baseline] (255.929 ms) : 0, 255929
GlobalTracer [candidate] (255.262 ms) : 0, 255262
AppSec [baseline] (33.535 ms) : 0, 33535
AppSec [candidate] (35.148 ms) : 0, 35148
Debugger [baseline] (65.874 ms) : 0, 65874
Debugger [candidate] (63.935 ms) : 0, 63935
Remote Config [baseline] (578.624 µs) : 0, 579
Remote Config [candidate] (600.3 µs) : 0, 600
Telemetry [baseline] (8.485 ms) : 0, 8485
Telemetry [candidate] (8.497 ms) : 0, 8497
Flare Poller [baseline] (3.557 ms) : 0, 3557
Flare Poller [candidate] (3.521 ms) : 0, 3521
IAST [baseline] (27.021 ms) : 0, 27021
IAST [candidate] (27.092 ms) : 0, 27092
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~b84b27e5da, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section baseline
no_agent (19.137 ms) : 18939, 19335
. : milestone, 19137,
appsec (18.659 ms) : 18470, 18848
. : milestone, 18659,
code_origins (17.809 ms) : 17630, 17989
. : milestone, 17809,
iast (17.623 ms) : 17448, 17798
. : milestone, 17623,
profiling (18.371 ms) : 18183, 18559
. : milestone, 18371,
tracing (17.636 ms) : 17461, 17811
. : milestone, 17636,
section candidate
no_agent (19.002 ms) : 18802, 19201
. : milestone, 19002,
appsec (18.623 ms) : 18433, 18814
. : milestone, 18623,
code_origins (17.73 ms) : 17558, 17903
. : milestone, 17730,
iast (18.137 ms) : 17957, 18318
. : milestone, 18137,
profiling (18.435 ms) : 18252, 18618
. : milestone, 18435,
tracing (17.494 ms) : 17326, 17662
. : milestone, 17494,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~b84b27e5da, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section baseline
no_agent (1.173 ms) : 1161, 1184
. : milestone, 1173,
iast (3.056 ms) : 3019, 3094
. : milestone, 3056,
iast_FULL (5.605 ms) : 5550, 5660
. : milestone, 5605,
iast_GLOBAL (3.554 ms) : 3503, 3605
. : milestone, 3554,
profiling (2.217 ms) : 2195, 2239
. : milestone, 2217,
tracing (1.838 ms) : 1821, 1855
. : milestone, 1838,
section candidate
no_agent (1.195 ms) : 1183, 1207
. : milestone, 1195,
iast (3.199 ms) : 3159, 3239
. : milestone, 3199,
iast_FULL (5.509 ms) : 5455, 5562
. : milestone, 5509,
iast_GLOBAL (3.641 ms) : 3588, 3694
. : milestone, 3641,
profiling (2.154 ms) : 2136, 2173
. : milestone, 2154,
tracing (1.74 ms) : 1727, 1754
. : milestone, 1740,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~b84b27e5da, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section baseline
no_agent (14.496 s) : 14496000, 14496000
. : milestone, 14496000,
appsec (14.587 s) : 14587000, 14587000
. : milestone, 14587000,
iast (17.716 s) : 17716000, 17716000
. : milestone, 17716000,
iast_GLOBAL (17.351 s) : 17351000, 17351000
. : milestone, 17351000,
profiling (14.181 s) : 14181000, 14181000
. : milestone, 14181000,
tracing (14.364 s) : 14364000, 14364000
. : milestone, 14364000,
section candidate
no_agent (14.89 s) : 14890000, 14890000
. : milestone, 14890000,
appsec (14.117 s) : 14117000, 14117000
. : milestone, 14117000,
iast (17.33 s) : 17330000, 17330000
. : milestone, 17330000,
iast_GLOBAL (17.269 s) : 17269000, 17269000
. : milestone, 17269000,
profiling (14.311 s) : 14311000, 14311000
. : milestone, 14311000,
tracing (14.151 s) : 14151000, 14151000
. : milestone, 14151000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~b84b27e5da, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section baseline
no_agent (1.486 ms) : 1475, 1498
. : milestone, 1486,
appsec (4.198 ms) : 3942, 4454
. : milestone, 4198,
iast (2.59 ms) : 2488, 2693
. : milestone, 2590,
iast_GLOBAL (2.625 ms) : 2523, 2728
. : milestone, 2625,
profiling (2.448 ms) : 2359, 2537
. : milestone, 2448,
tracing (2.381 ms) : 2296, 2465
. : milestone, 2381,
section candidate
no_agent (1.487 ms) : 1476, 1499
. : milestone, 1487,
appsec (4.187 ms) : 3932, 4442
. : milestone, 4187,
iast (2.593 ms) : 2490, 2695
. : milestone, 2593,
iast_GLOBAL (2.633 ms) : 2530, 2736
. : milestone, 2633,
profiling (2.422 ms) : 2334, 2510
. : milestone, 2422,
tracing (2.383 ms) : 2299, 2467
. : milestone, 2383,
|
AlexeyKuznetsov-DD
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: others
All other instrumentations
tag: telemetry error reported
Reported by error telemetry
type: bug
Bug report and fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
It does not cause functional issue - however it produces annoying telemetry signals.
Should solve:
Note: the code is inlined reason why there is no direct relationship
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]