Track server context in netty4 instrumentation by mcculls · Pull Request #10556 · DataDog/dd-trace-java

mcculls · 2026-02-09T12:37:10Z

Motivation

We should track the full server context and not just the span, to avoid potentially losing custom context when re-attaching the server context.

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any other useful labels
Avoid using close, fix, or any linking keywords when referencing an issue
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, migration, or deletion
Update public documentation with any new configuration flags or behaviors

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

PerfectSlayer

Make sense 👍 Thanks for the fix!

pr-commenter · 2026-02-09T13:23:39Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/netty4-server-context
git_commit_date	1770571409	1770640571
git_commit_sha	`d10055d`	`6ccc620`
release_version	1.60.0-SNAPSHOT~d10055d2a1	1.60.0-SNAPSHOT~6ccc620cd3

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1770642380	1770642380
ci_job_id	1409334949	1409334949
ci_pipeline_id	95208317	95208317
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-w2iqfdl2 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-w2iqfdl2 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~6ccc620cd3, baseline=1.60.0-SNAPSHOT~d10055d2a1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071712
Total [baseline] (10.932 s) : 0, 10931696
Agent [candidate] (1.073 s) : 0, 1072863
Total [candidate] (10.925 s) : 0, 10924735
section appsec
Agent [baseline] (1.248 s) : 0, 1247751
Total [baseline] (11.067 s) : 0, 11067062
Agent [candidate] (1.242 s) : 0, 1241589
Total [candidate] (11.134 s) : 0, 11134153
section iast
Agent [baseline] (1.233 s) : 0, 1233309
Total [baseline] (11.262 s) : 0, 11262038
Agent [candidate] (1.236 s) : 0, 1236274
Total [candidate] (11.18 s) : 0, 11179678
section profiling
Agent [baseline] (1.196 s) : 0, 1195708
Total [baseline] (10.973 s) : 0, 10972765
Agent [candidate] (1.191 s) : 0, 1190750
Total [candidate] (10.98 s) : 0, 10979937

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.072 s	-
Agent	appsec	1.248 s	176.039 ms (16.4%)
Agent	iast	1.233 s	161.597 ms (15.1%)
Agent	profiling	1.196 s	123.996 ms (11.6%)
Total	tracing	10.932 s	-
Total	appsec	11.067 s	135.366 ms (1.2%)
Total	iast	11.262 s	330.342 ms (3.0%)
Total	profiling	10.973 s	41.069 ms (0.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.073 s	-
Agent	appsec	1.242 s	168.725 ms (15.7%)
Agent	iast	1.236 s	163.411 ms (15.2%)
Agent	profiling	1.191 s	117.886 ms (11.0%)
Total	tracing	10.925 s	-
Total	appsec	11.134 s	209.417 ms (1.9%)
Total	iast	11.18 s	254.943 ms (2.3%)
Total	profiling	10.98 s	55.202 ms (0.5%)

gantt
    title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~6ccc620cd3, baseline=1.60.0-SNAPSHOT~d10055d2a1

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (633.863 ms) : 0, 633863
BytebuddyAgent [candidate] (633.979 ms) : 0, 633979
AgentMeter [baseline] (29.115 ms) : 0, 29115
AgentMeter [candidate] (29.089 ms) : 0, 29089
GlobalTracer [baseline] (259.547 ms) : 0, 259547
GlobalTracer [candidate] (259.875 ms) : 0, 259875
AppSec [baseline] (33.053 ms) : 0, 33053
AppSec [candidate] (33.065 ms) : 0, 33065
Debugger [baseline] (62.005 ms) : 0, 62005
Debugger [candidate] (63.066 ms) : 0, 63066
Remote Config [baseline] (624.336 µs) : 0, 624
Remote Config [candidate] (634.451 µs) : 0, 634
Telemetry [baseline] (11.569 ms) : 0, 11569
Telemetry [candidate] (12.102 ms) : 0, 12102
Flare Poller [baseline] (5.335 ms) : 0, 5335
Flare Poller [candidate] (4.489 ms) : 0, 4489
section appsec
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (663.309 ms) : 0, 663309
BytebuddyAgent [candidate] (659.804 ms) : 0, 659804
AgentMeter [baseline] (11.996 ms) : 0, 11996
AgentMeter [candidate] (11.971 ms) : 0, 11971
GlobalTracer [baseline] (260.14 ms) : 0, 260140
GlobalTracer [candidate] (259.41 ms) : 0, 259410
IAST [baseline] (25.544 ms) : 0, 25544
IAST [candidate] (25.306 ms) : 0, 25306
AppSec [baseline] (169.965 ms) : 0, 169965
AppSec [candidate] (167.732 ms) : 0, 167732
Debugger [baseline] (66.744 ms) : 0, 66744
Debugger [candidate] (67.381 ms) : 0, 67381
Remote Config [baseline] (664.222 µs) : 0, 664
Remote Config [candidate] (667.082 µs) : 0, 667
Telemetry [baseline] (9.081 ms) : 0, 9081
Telemetry [candidate] (9.13 ms) : 0, 9130
Flare Poller [baseline] (3.707 ms) : 0, 3707
Flare Poller [candidate] (3.667 ms) : 0, 3667
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (796.253 ms) : 0, 796253
BytebuddyAgent [candidate] (798.646 ms) : 0, 798646
AgentMeter [baseline] (11.235 ms) : 0, 11235
AgentMeter [candidate] (11.275 ms) : 0, 11275
GlobalTracer [baseline] (248.696 ms) : 0, 248696
GlobalTracer [candidate] (249.544 ms) : 0, 249544
IAST [baseline] (27.072 ms) : 0, 27072
IAST [candidate] (26.959 ms) : 0, 26959
AppSec [baseline] (33.281 ms) : 0, 33281
AppSec [candidate] (34.021 ms) : 0, 34021
Debugger [baseline] (67.655 ms) : 0, 67655
Debugger [candidate] (66.583 ms) : 0, 66583
Remote Config [baseline] (548.013 µs) : 0, 548
Remote Config [candidate] (547.794 µs) : 0, 548
Telemetry [baseline] (8.649 ms) : 0, 8649
Telemetry [candidate] (8.726 ms) : 0, 8726
Flare Poller [baseline] (3.515 ms) : 0, 3515
Flare Poller [candidate] (3.486 ms) : 0, 3486
section profiling
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (685.66 ms) : 0, 685660
BytebuddyAgent [candidate] (683.117 ms) : 0, 683117
AgentMeter [baseline] (8.604 ms) : 0, 8604
AgentMeter [candidate] (8.538 ms) : 0, 8538
GlobalTracer [baseline] (216.768 ms) : 0, 216768
GlobalTracer [candidate] (216.067 ms) : 0, 216067
AppSec [baseline] (32.769 ms) : 0, 32769
AppSec [candidate] (32.287 ms) : 0, 32287
Debugger [baseline] (67.933 ms) : 0, 67933
Debugger [candidate] (67.41 ms) : 0, 67410
Remote Config [baseline] (609.239 µs) : 0, 609
Remote Config [candidate] (597.702 µs) : 0, 598
Telemetry [baseline] (8.883 ms) : 0, 8883
Telemetry [candidate] (8.777 ms) : 0, 8777
Flare Poller [baseline] (3.821 ms) : 0, 3821
Flare Poller [candidate] (3.778 ms) : 0, 3778
ProfilingAgent [baseline] (99.362 ms) : 0, 99362
ProfilingAgent [candidate] (99.305 ms) : 0, 99305
Profiling [baseline] (99.928 ms) : 0, 99928
Profiling [candidate] (99.871 ms) : 0, 99871

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~6ccc620cd3, baseline=1.60.0-SNAPSHOT~d10055d2a1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1081980
Total [baseline] (8.83 s) : 0, 8830492
Agent [candidate] (1.068 s) : 0, 1068083
Total [candidate] (8.784 s) : 0, 8783646
section iast
Agent [baseline] (1.241 s) : 0, 1241236
Total [baseline] (9.397 s) : 0, 9397195
Agent [candidate] (1.237 s) : 0, 1237014
Total [candidate] (9.427 s) : 0, 9427000

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.082 s	-
Agent	iast	1.241 s	159.256 ms (14.7%)
Total	tracing	8.83 s	-
Total	iast	9.397 s	566.704 ms (6.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.068 s	-
Agent	iast	1.237 s	168.931 ms (15.8%)
Total	tracing	8.784 s	-
Total	iast	9.427 s	643.355 ms (7.3%)

gantt
    title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~6ccc620cd3, baseline=1.60.0-SNAPSHOT~d10055d2a1

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (639.665 ms) : 0, 639665
BytebuddyAgent [candidate] (633.086 ms) : 0, 633086
AgentMeter [baseline] (29.369 ms) : 0, 29369
AgentMeter [candidate] (28.994 ms) : 0, 28994
GlobalTracer [baseline] (261.141 ms) : 0, 261141
GlobalTracer [candidate] (258.371 ms) : 0, 258371
AppSec [baseline] (33.428 ms) : 0, 33428
AppSec [candidate] (32.89 ms) : 0, 32890
Debugger [baseline] (60.576 ms) : 0, 60576
Debugger [candidate] (60.879 ms) : 0, 60879
Remote Config [baseline] (701.769 µs) : 0, 702
Remote Config [candidate] (642.148 µs) : 0, 642
Telemetry [baseline] (12.52 ms) : 0, 12520
Telemetry [candidate] (9.957 ms) : 0, 9957
Flare Poller [baseline] (7.718 ms) : 0, 7718
Flare Poller [candidate] (6.858 ms) : 0, 6858
section iast
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (802.333 ms) : 0, 802333
BytebuddyAgent [candidate] (800.954 ms) : 0, 800954
AgentMeter [baseline] (11.488 ms) : 0, 11488
AgentMeter [candidate] (11.263 ms) : 0, 11263
GlobalTracer [baseline] (250.253 ms) : 0, 250253
GlobalTracer [candidate] (249.308 ms) : 0, 249308
IAST [baseline] (27.089 ms) : 0, 27089
IAST [candidate] (26.834 ms) : 0, 26834
AppSec [baseline] (35.017 ms) : 0, 35017
AppSec [candidate] (33.042 ms) : 0, 33042
Debugger [baseline] (65.591 ms) : 0, 65591
Debugger [candidate] (66.325 ms) : 0, 66325
Remote Config [baseline] (554.062 µs) : 0, 554
Remote Config [candidate] (540.37 µs) : 0, 540
Telemetry [baseline] (8.729 ms) : 0, 8729
Telemetry [candidate] (8.654 ms) : 0, 8654
Flare Poller [baseline] (3.513 ms) : 0, 3513
Flare Poller [candidate] (3.476 ms) : 0, 3476

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/netty4-server-context
git_commit_date	1770571409	1770640571
git_commit_sha	`d10055d`	`6ccc620`
release_version	1.60.0-SNAPSHOT~d10055d2a1	1.60.0-SNAPSHOT~6ccc620cd3

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1770642871	1770642871
ci_job_id	1409334950	1409334950
ci_pipeline_id	95208317	95208317
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-cxyimckz 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-cxyimckz 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 4 performance improvements and 4 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:petclinic:iast:high_load	better [-1337.562µs; -388.891µs] or [-7.257%; -2.110%]	better [-2.027ms; -0.774ms] or [-6.775%; -2.585%]	unstable [-16.259op/s; +40.884op/s] or [-6.518%; +16.389%]	17.569ms	28.521ms	261.781op/s	18.432ms	29.922ms	249.469op/s
scenario:load:petclinic:no_agent:high_load	better [-2.943ms; -1.476ms] or [-15.682%; -7.867%]	better [-3.976ms; -1.040ms] or [-12.940%; -3.384%]	unstable [-0.465op/s; +59.152op/s] or [-0.191%; +24.339%]	16.557ms	28.215ms	272.375op/s	18.766ms	30.722ms	243.031op/s
scenario:load:petclinic:tracing:high_load	worse [+0.867ms; +1.664ms] or [+5.068%; +9.718%]	unsure [+0.477ms; +2.956ms] or [+1.672%; +10.362%]	unstable [-44.133op/s; +14.070op/s] or [-16.617%; +5.298%]	18.383ms	30.242ms	250.562op/s	17.118ms	28.525ms	265.594op/s
scenario:load:petclinic:profiling:high_load	worse [+521.058µs; +1402.205µs] or [+2.843%; +7.651%]	worse [+0.684ms; +2.430ms] or [+2.278%; +8.087%]	unstable [-39.000op/s; +16.188op/s] or [-15.653%; +6.497%]	19.288ms	31.598ms	237.750op/s	18.326ms	30.041ms	249.156op/s
scenario:load:petclinic:appsec:high_load	worse [+478.845µs; +1439.751µs] or [+2.627%; +7.897%]	unsure [+0.446ms; +1.944ms] or [+1.489%; +6.488%]	unstable [-37.297op/s; +17.360op/s] or [-14.898%; +6.934%]	19.190ms	31.163ms	240.375op/s	18.231ms	29.968ms	250.344op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~6ccc620cd3, baseline=1.60.0-SNAPSHOT~d10055d2a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.181 ms) : 1170, 1193
.   : milestone, 1181,
iast (3.247 ms) : 3203, 3292
.   : milestone, 3247,
iast_FULL (5.806 ms) : 5748, 5864
.   : milestone, 5806,
iast_GLOBAL (3.721 ms) : 3661, 3780
.   : milestone, 3721,
profiling (1.963 ms) : 1947, 1979
.   : milestone, 1963,
tracing (1.783 ms) : 1768, 1798
.   : milestone, 1783,
section candidate
no_agent (1.172 ms) : 1161, 1183
.   : milestone, 1172,
iast (3.14 ms) : 3101, 3178
.   : milestone, 3140,
iast_FULL (5.806 ms) : 5747, 5864
.   : milestone, 5806,
iast_GLOBAL (3.706 ms) : 3636, 3775
.   : milestone, 3706,
profiling (2.082 ms) : 2063, 2100
.   : milestone, 2082,
tracing (1.805 ms) : 1790, 1820
.   : milestone, 1805,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.181 ms [1.17 ms, 1.193 ms]	-
iast	3.247 ms [3.203 ms, 3.292 ms]	2.066 ms (174.9%)
iast_FULL	5.806 ms [5.748 ms, 5.864 ms]	4.624 ms (391.5%)
iast_GLOBAL	3.721 ms [3.661 ms, 3.78 ms]	2.54 ms (215.0%)
profiling	1.963 ms [1.947 ms, 1.979 ms]	781.764 µs (66.2%)
tracing	1.783 ms [1.768 ms, 1.798 ms]	601.788 µs (50.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.172 ms [1.161 ms, 1.183 ms]	-
iast	3.14 ms [3.101 ms, 3.178 ms]	1.968 ms (167.9%)
iast_FULL	5.806 ms [5.747 ms, 5.864 ms]	4.634 ms (395.4%)
iast_GLOBAL	3.706 ms [3.636 ms, 3.775 ms]	2.534 ms (216.2%)
profiling	2.082 ms [2.063 ms, 2.1 ms]	909.553 µs (77.6%)
tracing	1.805 ms [1.79 ms, 1.82 ms]	633.469 µs (54.1%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~6ccc620cd3, baseline=1.60.0-SNAPSHOT~d10055d2a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.207 ms) : 19010, 19404
.   : milestone, 19207,
appsec (18.644 ms) : 18454, 18833
.   : milestone, 18644,
code_origins (17.816 ms) : 17643, 17990
.   : milestone, 17816,
iast (18.709 ms) : 18522, 18897
.   : milestone, 18709,
profiling (18.734 ms) : 18544, 18923
.   : milestone, 18734,
tracing (17.565 ms) : 17390, 17739
.   : milestone, 17565,
section candidate
no_agent (17.127 ms) : 16954, 17299
.   : milestone, 17127,
appsec (19.42 ms) : 19218, 19622
.   : milestone, 19420,
code_origins (17.798 ms) : 17622, 17974
.   : milestone, 17798,
iast (17.827 ms) : 17650, 18003
.   : milestone, 17827,
profiling (19.635 ms) : 19433, 19837
.   : milestone, 19635,
tracing (18.624 ms) : 18438, 18811
.   : milestone, 18624,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.207 ms [19.01 ms, 19.404 ms]	-
appsec	18.644 ms [18.454 ms, 18.833 ms]	-563.608 µs (-2.9%)
code_origins	17.816 ms [17.643 ms, 17.99 ms]	-1.391 ms (-7.2%)
iast	18.709 ms [18.522 ms, 18.897 ms]	-498.005 µs (-2.6%)
profiling	18.734 ms [18.544 ms, 18.923 ms]	-473.382 µs (-2.5%)
tracing	17.565 ms [17.39 ms, 17.739 ms]	-1.643 ms (-8.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	17.127 ms [16.954 ms, 17.299 ms]	-
appsec	19.42 ms [19.218 ms, 19.622 ms]	2.293 ms (13.4%)
code_origins	17.798 ms [17.622 ms, 17.974 ms]	671.683 µs (3.9%)
iast	17.827 ms [17.65 ms, 18.003 ms]	700.005 µs (4.1%)
profiling	19.635 ms [19.433 ms, 19.837 ms]	2.509 ms (14.6%)
tracing	18.624 ms [18.438 ms, 18.811 ms]	1.498 ms (8.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/netty4-server-context
git_commit_date	1770571409	1770640571
git_commit_sha	`d10055d`	`6ccc620`
release_version	1.60.0-SNAPSHOT~d10055d2a1	1.60.0-SNAPSHOT~6ccc620cd3

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1770642484	1770642484
ci_job_id	1409334951	1409334951
ci_pipeline_id	95208317	95208317
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-o5vmeg9b 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-o5vmeg9b 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~6ccc620cd3, baseline=1.60.0-SNAPSHOT~d10055d2a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.109 s) : 15109000, 15109000
.   : milestone, 15109000,
appsec (14.554 s) : 14554000, 14554000
.   : milestone, 14554000,
iast (18.344 s) : 18344000, 18344000
.   : milestone, 18344000,
iast_GLOBAL (18.717 s) : 18717000, 18717000
.   : milestone, 18717000,
profiling (15.673 s) : 15673000, 15673000
.   : milestone, 15673000,
tracing (14.628 s) : 14628000, 14628000
.   : milestone, 14628000,
section candidate
no_agent (15.67 s) : 15670000, 15670000
.   : milestone, 15670000,
appsec (15.023 s) : 15023000, 15023000
.   : milestone, 15023000,
iast (17.569 s) : 17569000, 17569000
.   : milestone, 17569000,
iast_GLOBAL (17.774 s) : 17774000, 17774000
.   : milestone, 17774000,
profiling (15.149 s) : 15149000, 15149000
.   : milestone, 15149000,
tracing (15.094 s) : 15094000, 15094000
.   : milestone, 15094000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.109 s [15.109 s, 15.109 s]	-
appsec	14.554 s [14.554 s, 14.554 s]	-555.0 ms (-3.7%)
iast	18.344 s [18.344 s, 18.344 s]	3.235 s (21.4%)
iast_GLOBAL	18.717 s [18.717 s, 18.717 s]	3.608 s (23.9%)
profiling	15.673 s [15.673 s, 15.673 s]	564.0 ms (3.7%)
tracing	14.628 s [14.628 s, 14.628 s]	-481.0 ms (-3.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.67 s [15.67 s, 15.67 s]	-
appsec	15.023 s [15.023 s, 15.023 s]	-647.0 ms (-4.1%)
iast	17.569 s [17.569 s, 17.569 s]	1.899 s (12.1%)
iast_GLOBAL	17.774 s [17.774 s, 17.774 s]	2.104 s (13.4%)
profiling	15.149 s [15.149 s, 15.149 s]	-521.0 ms (-3.3%)
tracing	15.094 s [15.094 s, 15.094 s]	-576.0 ms (-3.7%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~6ccc620cd3, baseline=1.60.0-SNAPSHOT~d10055d2a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (3.747 ms) : 3527, 3967
.   : milestone, 3747,
iast (2.255 ms) : 2185, 2325
.   : milestone, 2255,
iast_GLOBAL (2.3 ms) : 2230, 2370
.   : milestone, 2300,
profiling (2.083 ms) : 2028, 2138
.   : milestone, 2083,
tracing (2.072 ms) : 2019, 2126
.   : milestone, 2072,
section candidate
no_agent (1.475 ms) : 1464, 1487
.   : milestone, 1475,
appsec (3.764 ms) : 3542, 3987
.   : milestone, 3764,
iast (2.254 ms) : 2185, 2324
.   : milestone, 2254,
iast_GLOBAL (2.301 ms) : 2231, 2371
.   : milestone, 2301,
profiling (2.094 ms) : 2038, 2151
.   : milestone, 2094,
tracing (2.06 ms) : 2006, 2114
.   : milestone, 2060,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	3.747 ms [3.527 ms, 3.967 ms]	2.274 ms (154.4%)
iast	2.255 ms [2.185 ms, 2.325 ms]	782.206 µs (53.1%)
iast_GLOBAL	2.3 ms [2.23 ms, 2.37 ms]	827.283 µs (56.2%)
profiling	2.083 ms [2.028 ms, 2.138 ms]	610.314 µs (41.4%)
tracing	2.072 ms [2.019 ms, 2.126 ms]	599.676 µs (40.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.464 ms, 1.487 ms]	-
appsec	3.764 ms [3.542 ms, 3.987 ms]	2.289 ms (155.2%)
iast	2.254 ms [2.185 ms, 2.324 ms]	779.248 µs (52.8%)
iast_GLOBAL	2.301 ms [2.231 ms, 2.371 ms]	826.248 µs (56.0%)
profiling	2.094 ms [2.038 ms, 2.151 ms]	619.257 µs (42.0%)
tracing	2.06 ms [2.006 ms, 2.114 ms]	584.921 µs (39.7%)

mcculls · 2026-02-09T14:26:20Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-02-09T14:26:27Z

View all feedbacks in Devflow UI.

2026-02-09 14:26:26 UTC ℹ️ Start processing command /merge

2026-02-09 14:26:35 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-02-09 15:15:18 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.

2026-02-09 16:06:24 UTC 🚨 MergeQueue: This merge request is in error

mergequeue build completed successfully, but the github api returned an error while merging the pr

Details

Error: PUT https://api.github.com/repos/DataDog/dd-trace-java/pulls/10556/merge: 405 Repository rule violations found

Changes must be made through the merge queue

[] (Request ID: 8D9C:1EBEA3:75915:1FA1A9:698A05EF)

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 52, startedEventID: 53, identity: 1@github-worker-846f49f865-xpcmn@): PUT https://api.github.com/repos/DataDog/dd-trace-java/pulls/10556/merge: 405 Repository rule violations found

Changes must be made through the merge queue

[] (Request ID: 8D9C:1EBEA3:75915:1FA1A9:698A05EF) (type: GitFailure, retryable: false): PUT https://api.github.com/repos/DataDog/dd-trace-java/pulls/10556/merge: 405 Repository rule violations found

Changes must be made through the merge queue

[] (type: ErrorResponse, retryable: true)

mcculls · 2026-02-09T22:13:33Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-02-09T22:13:37Z

View all feedbacks in Devflow UI.

2026-02-09 22:13:37 UTC ℹ️ Start processing command /merge

2026-02-09 22:13:43 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-02-09 23:04:23 UTC ℹ️ MergeQueue: This merge request was merged

Track server context in netty4 instrumentation

6ccc620

mcculls requested a review from a team as a code owner February 9, 2026 12:37

mcculls added type: bug Bug report and fix inst: netty Netty instrumentation labels Feb 9, 2026

mcculls requested a review from PerfectSlayer February 9, 2026 12:37

PerfectSlayer approved these changes Feb 9, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d bot merged commit 73b2611 into master Feb 9, 2026
724 of 726 checks passed

gh-worker-dd-mergequeue-cf854d bot deleted the mcculls/netty4-server-context branch February 9, 2026 23:04

github-actions bot added this to the 1.60.0 milestone Feb 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Track server context in netty4 instrumentation#10556

Track server context in netty4 instrumentation#10556
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
mcculls/netty4-server-context

mcculls commented Feb 9, 2026

Uh oh!

PerfectSlayer left a comment

Uh oh!

pr-commenter bot commented Feb 9, 2026

Uh oh!

mcculls commented Feb 9, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

mcculls commented Feb 9, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mcculls commented Feb 9, 2026

Motivation

Contributor Checklist

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

pr-commenter bot commented Feb 9, 2026

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

mcculls commented Feb 9, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcculls commented Feb 9, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gh-worker-devflow-routing-ef8351 bot commented Feb 9, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 bot commented Feb 9, 2026 •

edited

Loading