Convert build time instrumentation plugin from Groovy to Kotlin#10727
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~0c828c9219, baseline=1.61.0-SNAPSHOT~9ab451433f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055673
Total [baseline] (10.99 s) : 0, 10989540
Agent [candidate] (1.056 s) : 0, 1056126
Total [candidate] (11.056 s) : 0, 11056191
section appsec
Agent [baseline] (1.239 s) : 0, 1239154
Total [baseline] (11.117 s) : 0, 11117060
Agent [candidate] (1.258 s) : 0, 1257814
Total [candidate] (11.121 s) : 0, 11121472
section iast
Agent [baseline] (1.227 s) : 0, 1227028
Total [baseline] (11.439 s) : 0, 11439102
Agent [candidate] (1.225 s) : 0, 1224748
Total [candidate] (11.321 s) : 0, 11320945
section profiling
Agent [baseline] (1.18 s) : 0, 1180258
Total [baseline] (11.048 s) : 0, 11047603
Agent [candidate] (1.182 s) : 0, 1182021
Total [candidate] (11.03 s) : 0, 11030382
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~0c828c9219, baseline=1.61.0-SNAPSHOT~9ab451433f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (626.58 ms) : 0, 626580
BytebuddyAgent [candidate] (627.783 ms) : 0, 627783
AgentMeter [baseline] (28.965 ms) : 0, 28965
AgentMeter [candidate] (29.131 ms) : 0, 29131
GlobalTracer [baseline] (255.995 ms) : 0, 255995
GlobalTracer [candidate] (256.455 ms) : 0, 256455
AppSec [baseline] (31.402 ms) : 0, 31402
AppSec [candidate] (31.465 ms) : 0, 31465
Debugger [baseline] (59.248 ms) : 0, 59248
Debugger [candidate] (59.204 ms) : 0, 59204
Remote Config [baseline] (580.925 µs) : 0, 581
Remote Config [candidate] (587.548 µs) : 0, 588
Telemetry [baseline] (8.624 ms) : 0, 8624
Telemetry [candidate] (8.631 ms) : 0, 8631
Flare Poller [baseline] (7.188 ms) : 0, 7188
Flare Poller [candidate] (5.715 ms) : 0, 5715
section appsec
crashtracking [baseline] (1.166 ms) : 0, 1166
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (655.219 ms) : 0, 655219
BytebuddyAgent [candidate] (665.623 ms) : 0, 665623
AgentMeter [baseline] (11.986 ms) : 0, 11986
AgentMeter [candidate] (12.09 ms) : 0, 12090
GlobalTracer [baseline] (256.329 ms) : 0, 256329
GlobalTracer [candidate] (260.559 ms) : 0, 260559
IAST [baseline] (23.85 ms) : 0, 23850
IAST [candidate] (24.279 ms) : 0, 24279
AppSec [baseline] (176.533 ms) : 0, 176533
AppSec [candidate] (178.568 ms) : 0, 178568
Debugger [baseline] (64.999 ms) : 0, 64999
Debugger [candidate] (65.801 ms) : 0, 65801
Remote Config [baseline] (565.455 µs) : 0, 565
Remote Config [candidate] (568.804 µs) : 0, 569
Telemetry [baseline] (8.856 ms) : 0, 8856
Telemetry [candidate] (9.084 ms) : 0, 9084
Flare Poller [baseline] (3.543 ms) : 0, 3543
Flare Poller [candidate] (3.589 ms) : 0, 3589
section iast
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (796.103 ms) : 0, 796103
BytebuddyAgent [candidate] (794.104 ms) : 0, 794104
AgentMeter [baseline] (11.336 ms) : 0, 11336
AgentMeter [candidate] (11.276 ms) : 0, 11276
GlobalTracer [baseline] (246.885 ms) : 0, 246885
GlobalTracer [candidate] (246.79 ms) : 0, 246790
IAST [baseline] (25.171 ms) : 0, 25171
IAST [candidate] (25.092 ms) : 0, 25092
AppSec [baseline] (26.454 ms) : 0, 26454
AppSec [candidate] (26.343 ms) : 0, 26343
Debugger [baseline] (63.281 ms) : 0, 63281
Debugger [candidate] (63.758 ms) : 0, 63758
Remote Config [baseline] (525.693 µs) : 0, 526
Remote Config [candidate] (535.444 µs) : 0, 535
Telemetry [baseline] (14.94 ms) : 0, 14940
Telemetry [candidate] (14.843 ms) : 0, 14843
Flare Poller [baseline] (5.107 ms) : 0, 5107
Flare Poller [candidate] (4.964 ms) : 0, 4964
section profiling
crashtracking [baseline] (1.166 ms) : 0, 1166
crashtracking [candidate] (1.16 ms) : 0, 1160
BytebuddyAgent [baseline] (681.999 ms) : 0, 681999
BytebuddyAgent [candidate] (683.367 ms) : 0, 683367
AgentMeter [baseline] (8.555 ms) : 0, 8555
AgentMeter [candidate] (8.568 ms) : 0, 8568
GlobalTracer [baseline] (214.871 ms) : 0, 214871
GlobalTracer [candidate] (215.303 ms) : 0, 215303
AppSec [baseline] (31.908 ms) : 0, 31908
AppSec [candidate] (31.878 ms) : 0, 31878
Debugger [baseline] (61.256 ms) : 0, 61256
Debugger [candidate] (62.485 ms) : 0, 62485
Remote Config [baseline] (577.725 µs) : 0, 578
Remote Config [candidate] (573.152 µs) : 0, 573
Telemetry [baseline] (12.007 ms) : 0, 12007
Telemetry [candidate] (10.511 ms) : 0, 10511
Flare Poller [baseline] (3.491 ms) : 0, 3491
Flare Poller [candidate] (3.471 ms) : 0, 3471
ProfilingAgent [baseline] (93.685 ms) : 0, 93685
ProfilingAgent [candidate] (93.948 ms) : 0, 93948
Profiling [baseline] (94.251 ms) : 0, 94251
Profiling [candidate] (94.518 ms) : 0, 94518
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~0c828c9219, baseline=1.61.0-SNAPSHOT~9ab451433f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052102
Total [baseline] (8.858 s) : 0, 8857771
Agent [candidate] (1.067 s) : 0, 1066652
Total [candidate] (8.826 s) : 0, 8825977
section iast
Agent [baseline] (1.225 s) : 0, 1225086
Total [baseline] (9.608 s) : 0, 9608310
Agent [candidate] (1.234 s) : 0, 1234180
Total [candidate] (9.574 s) : 0, 9574266
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~0c828c9219, baseline=1.61.0-SNAPSHOT~9ab451433f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.165 ms) : 0, 1165
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (626.806 ms) : 0, 626806
BytebuddyAgent [candidate] (633.029 ms) : 0, 633029
AgentMeter [baseline] (29.036 ms) : 0, 29036
AgentMeter [candidate] (29.309 ms) : 0, 29309
GlobalTracer [baseline] (254.836 ms) : 0, 254836
GlobalTracer [candidate] (258.231 ms) : 0, 258231
AppSec [baseline] (31.485 ms) : 0, 31485
AppSec [candidate] (31.729 ms) : 0, 31729
Debugger [baseline] (58.27 ms) : 0, 58270
Debugger [candidate] (59.049 ms) : 0, 59049
Remote Config [baseline] (562.452 µs) : 0, 562
Remote Config [candidate] (584.1 µs) : 0, 584
Telemetry [baseline] (8.552 ms) : 0, 8552
Telemetry [candidate] (8.67 ms) : 0, 8670
Flare Poller [baseline] (5.58 ms) : 0, 5580
Flare Poller [candidate] (8.692 ms) : 0, 8692
section iast
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (795.208 ms) : 0, 795208
BytebuddyAgent [candidate] (802.452 ms) : 0, 802452
AgentMeter [baseline] (11.297 ms) : 0, 11297
AgentMeter [candidate] (11.569 ms) : 0, 11569
GlobalTracer [baseline] (246.822 ms) : 0, 246822
GlobalTracer [candidate] (248.536 ms) : 0, 248536
IAST [baseline] (25.18 ms) : 0, 25180
IAST [candidate] (25.376 ms) : 0, 25376
AppSec [baseline] (26.335 ms) : 0, 26335
AppSec [candidate] (26.681 ms) : 0, 26681
Debugger [baseline] (62.624 ms) : 0, 62624
Debugger [candidate] (62.144 ms) : 0, 62144
Remote Config [baseline] (524.247 µs) : 0, 524
Remote Config [candidate] (510.072 µs) : 0, 510
Telemetry [baseline] (14.885 ms) : 0, 14885
Telemetry [candidate] (14.711 ms) : 0, 14711
Flare Poller [baseline] (4.964 ms) : 0, 4964
Flare Poller [candidate] (4.871 ms) : 0, 4871
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 1 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~0c828c9219, baseline=1.61.0-SNAPSHOT~9ab451433f
dateFormat X
axisFormat %s
section baseline
no_agent (18.099 ms) : 17913, 18285
. : milestone, 18099,
appsec (18.428 ms) : 18244, 18613
. : milestone, 18428,
code_origins (17.965 ms) : 17787, 18144
. : milestone, 17965,
iast (17.756 ms) : 17580, 17932
. : milestone, 17756,
profiling (18.65 ms) : 18463, 18837
. : milestone, 18650,
tracing (17.504 ms) : 17333, 17676
. : milestone, 17504,
section candidate
no_agent (19.334 ms) : 19129, 19539
. : milestone, 19334,
appsec (19.492 ms) : 19295, 19690
. : milestone, 19492,
code_origins (17.732 ms) : 17559, 17906
. : milestone, 17732,
iast (17.796 ms) : 17617, 17974
. : milestone, 17796,
profiling (18.54 ms) : 18354, 18726
. : milestone, 18540,
tracing (17.905 ms) : 17727, 18083
. : milestone, 17905,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~0c828c9219, baseline=1.61.0-SNAPSHOT~9ab451433f
dateFormat X
axisFormat %s
section baseline
no_agent (1.189 ms) : 1178, 1201
. : milestone, 1189,
iast (3.292 ms) : 3248, 3336
. : milestone, 3292,
iast_FULL (5.813 ms) : 5755, 5871
. : milestone, 5813,
iast_GLOBAL (3.753 ms) : 3695, 3811
. : milestone, 3753,
profiling (2.172 ms) : 2149, 2194
. : milestone, 2172,
tracing (1.814 ms) : 1799, 1829
. : milestone, 1814,
section candidate
no_agent (1.172 ms) : 1161, 1183
. : milestone, 1172,
iast (3.179 ms) : 3134, 3224
. : milestone, 3179,
iast_FULL (5.601 ms) : 5545, 5657
. : milestone, 5601,
iast_GLOBAL (3.447 ms) : 3398, 3495
. : milestone, 3447,
profiling (2.239 ms) : 2218, 2260
. : milestone, 2239,
tracing (1.798 ms) : 1783, 1813
. : milestone, 1798,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~0c828c9219, baseline=1.61.0-SNAPSHOT~9ab451433f
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (2.536 ms) : 2481, 2592
. : milestone, 2536,
iast (2.259 ms) : 2189, 2329
. : milestone, 2259,
iast_GLOBAL (2.309 ms) : 2239, 2379
. : milestone, 2309,
profiling (2.085 ms) : 2030, 2140
. : milestone, 2085,
tracing (2.072 ms) : 2018, 2125
. : milestone, 2072,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.521 ms) : 2466, 2576
. : milestone, 2521,
iast (2.257 ms) : 2188, 2326
. : milestone, 2257,
iast_GLOBAL (2.297 ms) : 2227, 2366
. : milestone, 2297,
profiling (2.085 ms) : 2031, 2139
. : milestone, 2085,
tracing (2.071 ms) : 2017, 2125
. : milestone, 2071,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~0c828c9219, baseline=1.61.0-SNAPSHOT~9ab451433f
dateFormat X
axisFormat %s
section baseline
no_agent (14.919 s) : 14919000, 14919000
. : milestone, 14919000,
appsec (14.72 s) : 14720000, 14720000
. : milestone, 14720000,
iast (18.393 s) : 18393000, 18393000
. : milestone, 18393000,
iast_GLOBAL (17.652 s) : 17652000, 17652000
. : milestone, 17652000,
profiling (14.604 s) : 14604000, 14604000
. : milestone, 14604000,
tracing (15.043 s) : 15043000, 15043000
. : milestone, 15043000,
section candidate
no_agent (15.154 s) : 15154000, 15154000
. : milestone, 15154000,
appsec (14.628 s) : 14628000, 14628000
. : milestone, 14628000,
iast (18.115 s) : 18115000, 18115000
. : milestone, 18115000,
iast_GLOBAL (17.71 s) : 17710000, 17710000
. : milestone, 17710000,
profiling (15.392 s) : 15392000, 15392000
. : milestone, 15392000,
tracing (15.058 s) : 15058000, 15058000
. : milestone, 15058000,
|
6830bf6 to
9903231
Compare
9903231 to
0c828c9
Compare
|
Cool! Now we have no Groovy in
|
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
LGTM, but found minor issues with tests.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
|
/merge |
|
View all feedbacks in Devflow UI.
PR already in the queue with status queued |
What Does This Do
Improves type safety by converting build time instrumentation plugin to Kotlin.
Motivation
Getting rid of Groovy.
Additional Notes
New behavior fixed in #10735 remains tested by #10743.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.