Skip to content

Migrate dd-trace-api Groovy files to Java (part 2) #10776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 5 commits into from
Mar 10, 2026
+482 −445
Merged

Migrate dd-trace-api Groovy files to Java (part 2) #10776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b628e82
Migrate dd-trace-api Groovy files to Java (part 2)
sarahchen6 Mar 6, 2026
8452c62
Use Mockito
sarahchen6 Mar 9, 2026
09f6b4c
Update claude skill
sarahchen6 Mar 9, 2026
9945528
Fix list error
sarahchen6 Mar 9, 2026
ce94551
Merge branch 'master' into sarahchen6/g2j-dd-trace-api-migration-pt-2
sarahchen6 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .claude/skills/migrate-groovy-to-java/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,4 @@ When converting Groovy code to Java code, make sure that:
- Do not wrap checked exceptions and throw a Runtime exception; prefer adding a throws clause at method declaration
- Do not mark local variables `final`
- Ensure variables are human-readable; avoid single-letter names and pre-define variables that are referenced multiple times
- When translating Spock `Mock(...)` usage, use `libs.bundles.mockito` instead of writing manual recording/stub implementations
Copy link
Contributor Author

@sarahchen6 sarahchen6 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally the AI had implemented its own detailed inner classes where using mockito would be much cleaner. See b628e82

1 change: 1 addition & 0 deletions dd-trace-api/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,6 @@ description = "dd-trace-api"
dependencies {
api(libs.slf4j)
testImplementation(libs.guava)
testImplementation(libs.bundles.mockito)
testImplementation(project(":utils:test-utils"))
}
151 changes: 0 additions & 151 deletions dd-trace-api/src/test/groovy/datadog/trace/api/aiguard/AIGuardTest.groovy
View file
Open in desktop

This file was deleted.

Loading