Pin system tests to dd-trace-java-1.60.2-release branch#10898
Pin system tests to dd-trace-java-1.60.2-release branch#10898sarahchen6 merged 2 commits intorelease/v1.60.xfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~f4bb24d0aa, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071295
Total [baseline] (10.857 s) : 0, 10856679
Agent [candidate] (1.073 s) : 0, 1073158
Total [candidate] (10.876 s) : 0, 10876284
section appsec
Agent [baseline] (1.24 s) : 0, 1240217
Total [baseline] (10.971 s) : 0, 10971043
Agent [candidate] (1.237 s) : 0, 1236775
Total [candidate] (10.955 s) : 0, 10955155
section iast
Agent [baseline] (1.231 s) : 0, 1230676
Total [baseline] (11.168 s) : 0, 11167755
Agent [candidate] (1.231 s) : 0, 1230847
Total [candidate] (11.161 s) : 0, 11160506
section profiling
Agent [baseline] (1.2 s) : 0, 1199582
Total [baseline] (11.045 s) : 0, 11044559
Agent [candidate] (1.19 s) : 0, 1190180
Total [candidate] (10.861 s) : 0, 10861423
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~f4bb24d0aa, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (630.738 ms) : 0, 630738
BytebuddyAgent [candidate] (632.302 ms) : 0, 632302
AgentMeter [baseline] (29.418 ms) : 0, 29418
AgentMeter [candidate] (29.244 ms) : 0, 29244
GlobalTracer [baseline] (259.775 ms) : 0, 259775
GlobalTracer [candidate] (259.007 ms) : 0, 259007
AppSec [baseline] (33.501 ms) : 0, 33501
AppSec [candidate] (33.146 ms) : 0, 33146
Debugger [baseline] (65.156 ms) : 0, 65156
Debugger [candidate] (66.126 ms) : 0, 66126
Remote Config [baseline] (626.425 µs) : 0, 626
Remote Config [candidate] (620.905 µs) : 0, 621
Telemetry [baseline] (9.961 ms) : 0, 9961
Telemetry [candidate] (9.936 ms) : 0, 9936
Flare Poller [baseline] (4.605 ms) : 0, 4605
Flare Poller [candidate] (5.429 ms) : 0, 5429
section appsec
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (659.047 ms) : 0, 659047
BytebuddyAgent [candidate] (656.288 ms) : 0, 656288
AgentMeter [baseline] (11.993 ms) : 0, 11993
AgentMeter [candidate] (11.965 ms) : 0, 11965
GlobalTracer [baseline] (258.28 ms) : 0, 258280
GlobalTracer [candidate] (258.008 ms) : 0, 258008
IAST [baseline] (25.362 ms) : 0, 25362
IAST [candidate] (25.274 ms) : 0, 25274
AppSec [baseline] (167.682 ms) : 0, 167682
AppSec [candidate] (167.417 ms) : 0, 167417
Debugger [baseline] (66.931 ms) : 0, 66931
Debugger [candidate] (66.923 ms) : 0, 66923
Remote Config [baseline] (704.791 µs) : 0, 705
Remote Config [candidate] (675.068 µs) : 0, 675
Telemetry [baseline] (9.312 ms) : 0, 9312
Telemetry [candidate] (9.327 ms) : 0, 9327
Flare Poller [baseline] (3.684 ms) : 0, 3684
Flare Poller [candidate] (3.725 ms) : 0, 3725
section iast
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (795.053 ms) : 0, 795053
BytebuddyAgent [candidate] (794.952 ms) : 0, 794952
AgentMeter [baseline] (11.29 ms) : 0, 11290
AgentMeter [candidate] (11.322 ms) : 0, 11322
GlobalTracer [baseline] (247.389 ms) : 0, 247389
GlobalTracer [candidate] (247.125 ms) : 0, 247125
IAST [baseline] (26.8 ms) : 0, 26800
IAST [candidate] (27.031 ms) : 0, 27031
AppSec [baseline] (33.927 ms) : 0, 33927
AppSec [candidate] (33.217 ms) : 0, 33217
Debugger [baseline] (66.572 ms) : 0, 66572
Debugger [candidate] (67.505 ms) : 0, 67505
Remote Config [baseline] (534.961 µs) : 0, 535
Remote Config [candidate] (537.205 µs) : 0, 537
Telemetry [baseline] (8.553 ms) : 0, 8553
Telemetry [candidate] (8.611 ms) : 0, 8611
Flare Poller [baseline] (3.436 ms) : 0, 3436
Flare Poller [candidate] (3.414 ms) : 0, 3414
section profiling
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.169 ms) : 0, 1169
BytebuddyAgent [baseline] (687.429 ms) : 0, 687429
BytebuddyAgent [candidate] (681.709 ms) : 0, 681709
AgentMeter [baseline] (8.595 ms) : 0, 8595
AgentMeter [candidate] (8.535 ms) : 0, 8535
GlobalTracer [baseline] (217.193 ms) : 0, 217193
GlobalTracer [candidate] (216.048 ms) : 0, 216048
AppSec [baseline] (33.111 ms) : 0, 33111
AppSec [candidate] (32.659 ms) : 0, 32659
Debugger [baseline] (67.577 ms) : 0, 67577
Debugger [candidate] (67.013 ms) : 0, 67013
Remote Config [baseline] (627.57 µs) : 0, 628
Remote Config [candidate] (633.12 µs) : 0, 633
Telemetry [baseline] (8.963 ms) : 0, 8963
Telemetry [candidate] (8.962 ms) : 0, 8962
Flare Poller [baseline] (3.764 ms) : 0, 3764
Flare Poller [candidate] (3.784 ms) : 0, 3784
ProfilingAgent [baseline] (99.91 ms) : 0, 99910
ProfilingAgent [candidate] (98.949 ms) : 0, 98949
Profiling [baseline] (100.505 ms) : 0, 100505
Profiling [candidate] (99.512 ms) : 0, 99512
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~f4bb24d0aa, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1072244
Total [baseline] (8.749 s) : 0, 8748573
Agent [candidate] (1.065 s) : 0, 1064702
Total [candidate] (8.726 s) : 0, 8725604
section iast
Agent [baseline] (1.228 s) : 0, 1227576
Total [baseline] (9.353 s) : 0, 9352541
Agent [candidate] (1.239 s) : 0, 1239470
Total [candidate] (9.415 s) : 0, 9415081
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~f4bb24d0aa, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (632.172 ms) : 0, 632172
BytebuddyAgent [candidate] (627.649 ms) : 0, 627649
AgentMeter [baseline] (29.247 ms) : 0, 29247
AgentMeter [candidate] (29.065 ms) : 0, 29065
GlobalTracer [baseline] (258.887 ms) : 0, 258887
GlobalTracer [candidate] (257.663 ms) : 0, 257663
AppSec [baseline] (33.303 ms) : 0, 33303
AppSec [candidate] (32.834 ms) : 0, 32834
Debugger [baseline] (62.791 ms) : 0, 62791
Debugger [candidate] (62.897 ms) : 0, 62897
Remote Config [baseline] (633.12 µs) : 0, 633
Remote Config [candidate] (619.556 µs) : 0, 620
Telemetry [baseline] (12.321 ms) : 0, 12321
Telemetry [candidate] (9.787 ms) : 0, 9787
Flare Poller [baseline] (5.499 ms) : 0, 5499
Flare Poller [candidate] (6.928 ms) : 0, 6928
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (793.361 ms) : 0, 793361
BytebuddyAgent [candidate] (801.865 ms) : 0, 801865
AgentMeter [baseline] (11.314 ms) : 0, 11314
AgentMeter [candidate] (11.549 ms) : 0, 11549
GlobalTracer [baseline] (246.449 ms) : 0, 246449
GlobalTracer [candidate] (248.451 ms) : 0, 248451
IAST [baseline] (27.042 ms) : 0, 27042
IAST [candidate] (27.27 ms) : 0, 27270
AppSec [baseline] (34.855 ms) : 0, 34855
AppSec [candidate] (32.618 ms) : 0, 32618
Debugger [baseline] (64.682 ms) : 0, 64682
Debugger [candidate] (67.771 ms) : 0, 67771
Remote Config [baseline] (543.909 µs) : 0, 544
Remote Config [candidate] (540.302 µs) : 0, 540
Telemetry [baseline] (8.641 ms) : 0, 8641
Telemetry [candidate] (8.662 ms) : 0, 8662
Flare Poller [baseline] (3.501 ms) : 0, 3501
Flare Poller [candidate] (3.499 ms) : 0, 3499
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 14 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~f4bb24d0aa, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section baseline
no_agent (17.971 ms) : 17790, 18153
. : milestone, 17971,
appsec (20.138 ms) : 19930, 20346
. : milestone, 20138,
code_origins (17.804 ms) : 17627, 17982
. : milestone, 17804,
iast (17.686 ms) : 17506, 17866
. : milestone, 17686,
profiling (18.559 ms) : 18370, 18748
. : milestone, 18559,
tracing (17.501 ms) : 17330, 17672
. : milestone, 17501,
section candidate
no_agent (19.561 ms) : 19357, 19765
. : milestone, 19561,
appsec (18.626 ms) : 18437, 18814
. : milestone, 18626,
code_origins (17.646 ms) : 17471, 17821
. : milestone, 17646,
iast (17.486 ms) : 17315, 17658
. : milestone, 17486,
profiling (18.616 ms) : 18429, 18802
. : milestone, 18616,
tracing (17.567 ms) : 17392, 17741
. : milestone, 17567,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~f4bb24d0aa, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section baseline
no_agent (1.307 ms) : 1294, 1321
. : milestone, 1307,
iast (3.173 ms) : 3128, 3218
. : milestone, 3173,
iast_FULL (5.938 ms) : 5877, 5999
. : milestone, 5938,
iast_GLOBAL (3.537 ms) : 3488, 3585
. : milestone, 3537,
profiling (2.008 ms) : 1989, 2027
. : milestone, 2008,
tracing (1.78 ms) : 1765, 1795
. : milestone, 1780,
section candidate
no_agent (1.182 ms) : 1171, 1194
. : milestone, 1182,
iast (3.288 ms) : 3238, 3338
. : milestone, 3288,
iast_FULL (5.776 ms) : 5718, 5833
. : milestone, 5776,
iast_GLOBAL (3.472 ms) : 3414, 3529
. : milestone, 3472,
profiling (2.276 ms) : 2252, 2299
. : milestone, 2276,
tracing (1.801 ms) : 1786, 1815
. : milestone, 1801,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~f4bb24d0aa, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section baseline
no_agent (15.361 s) : 15361000, 15361000
. : milestone, 15361000,
appsec (15.248 s) : 15248000, 15248000
. : milestone, 15248000,
iast (18.177 s) : 18177000, 18177000
. : milestone, 18177000,
iast_GLOBAL (17.63 s) : 17630000, 17630000
. : milestone, 17630000,
profiling (15.448 s) : 15448000, 15448000
. : milestone, 15448000,
tracing (14.749 s) : 14749000, 14749000
. : milestone, 14749000,
section candidate
no_agent (15.634 s) : 15634000, 15634000
. : milestone, 15634000,
appsec (15.04 s) : 15040000, 15040000
. : milestone, 15040000,
iast (17.978 s) : 17978000, 17978000
. : milestone, 17978000,
iast_GLOBAL (17.986 s) : 17986000, 17986000
. : milestone, 17986000,
profiling (15.046 s) : 15046000, 15046000
. : milestone, 15046000,
tracing (15.122 s) : 15122000, 15122000
. : milestone, 15122000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~f4bb24d0aa, baseline=1.60.0~0f5d84f2c4
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.807 ms) : 3586, 4029
. : milestone, 3807,
iast (2.277 ms) : 2207, 2347
. : milestone, 2277,
iast_GLOBAL (2.303 ms) : 2233, 2372
. : milestone, 2303,
profiling (2.094 ms) : 2038, 2150
. : milestone, 2094,
tracing (2.071 ms) : 2017, 2124
. : milestone, 2071,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.803 ms) : 3580, 4025
. : milestone, 3803,
iast (2.261 ms) : 2192, 2331
. : milestone, 2261,
iast_GLOBAL (2.297 ms) : 2228, 2367
. : milestone, 2297,
profiling (2.116 ms) : 2059, 2172
. : milestone, 2116,
tracing (2.073 ms) : 2019, 2127
. : milestone, 2073,
|
cb652de to
ec01b34
Compare
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
init Merge branch 'master' into mhlidd/update_telemetry_key_normalization Merge branch 'master' into mhlidd/update_telemetry_key_normalization Merge branch 'master' into mhlidd/update_telemetry_key_normalization Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
What Does This Do
Pin system-tests to the
dd-trace-java-1.60.2-releasebranch that updatesactions/download-artifact@v4(non-SHA pin, violates internal DataDog enterprise GitHub Actions policy) toactions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093(SHA pin, compliant with the policy)To get Gitlab system-tests to pass, we also need to update some telemetry configs.
Motivation
Additional Notes
Despite pinning system tests in our Github action workflow to a branch (which is why github tests are passing), gitlab tests are still pinned to the
mainsystem-tests branch here: https://github.com/DataDog/libdatadog-build/blob/main/templates/one-pipeline.yml#L514, causing gitlab system tests to fail.dd-trace-java-1.60.2-releasebranch updates are made in DataDog/system-tests#6535.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.