Strip queue:// and topic:// URI prefixes from IBM MQ JMS destination names#10909
Strip queue:// and topic:// URI prefixes from IBM MQ JMS destination names#10909johannbotha wants to merge 1 commit intomasterfrom
Conversation
…names
IBM MQ's JMS implementation can return URI-format names from
Queue.getQueueName() when destinations are created with URI syntax
(e.g. session.createQueue("queue:///MY.QUEUE")). This causes
queue:///... prefixed names to appear in DSM data.
Add sanitizeUriPrefix() to strip these prefixes (case-insensitive)
including any remaining leading slashes, applied before the existing
TIBCO and Kafka Connect sanitizations.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~d765eda60d, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057966
Total [baseline] (11.114 s) : 0, 11114275
Agent [candidate] (1.057 s) : 0, 1057383
Total [candidate] (11.115 s) : 0, 11115058
section appsec
Agent [baseline] (1.255 s) : 0, 1254974
Total [baseline] (11.215 s) : 0, 11215440
Agent [candidate] (1.252 s) : 0, 1252310
Total [candidate] (11.256 s) : 0, 11255935
section iast
Agent [baseline] (1.229 s) : 0, 1229364
Total [baseline] (11.34 s) : 0, 11339624
Agent [candidate] (1.235 s) : 0, 1234543
Total [candidate] (11.349 s) : 0, 11348610
section profiling
Agent [baseline] (1.19 s) : 0, 1189854
Total [baseline] (11.058 s) : 0, 11058457
Agent [candidate] (1.183 s) : 0, 1183098
Total [candidate] (11.041 s) : 0, 11040858
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~d765eda60d, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (628.702 ms) : 0, 628702
BytebuddyAgent [candidate] (628.574 ms) : 0, 628574
AgentMeter [baseline] (29.133 ms) : 0, 29133
AgentMeter [candidate] (29.195 ms) : 0, 29195
GlobalTracer [baseline] (256.478 ms) : 0, 256478
GlobalTracer [candidate] (256.934 ms) : 0, 256934
AppSec [baseline] (31.749 ms) : 0, 31749
AppSec [candidate] (31.631 ms) : 0, 31631
Debugger [baseline] (60.228 ms) : 0, 60228
Debugger [candidate] (60.2 ms) : 0, 60200
Remote Config [baseline] (592.645 µs) : 0, 593
Remote Config [candidate] (587.48 µs) : 0, 587
Telemetry [baseline] (8.064 ms) : 0, 8064
Telemetry [candidate] (8.033 ms) : 0, 8033
Flare Poller [baseline] (5.846 ms) : 0, 5846
Flare Poller [candidate] (5.038 ms) : 0, 5038
section appsec
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (663.127 ms) : 0, 663127
BytebuddyAgent [candidate] (661.625 ms) : 0, 661625
AgentMeter [baseline] (12.166 ms) : 0, 12166
AgentMeter [candidate] (12.102 ms) : 0, 12102
GlobalTracer [baseline] (259.651 ms) : 0, 259651
GlobalTracer [candidate] (258.866 ms) : 0, 258866
IAST [baseline] (24.437 ms) : 0, 24437
IAST [candidate] (24.325 ms) : 0, 24325
AppSec [baseline] (178.913 ms) : 0, 178913
AppSec [candidate] (178.598 ms) : 0, 178598
Debugger [baseline] (66.418 ms) : 0, 66418
Debugger [candidate] (66.544 ms) : 0, 66544
Remote Config [baseline] (631.08 µs) : 0, 631
Remote Config [candidate] (641.6 µs) : 0, 642
Telemetry [baseline] (8.383 ms) : 0, 8383
Telemetry [candidate] (8.329 ms) : 0, 8329
Flare Poller [baseline] (3.597 ms) : 0, 3597
Flare Poller [candidate] (3.598 ms) : 0, 3598
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (797.079 ms) : 0, 797079
BytebuddyAgent [candidate] (800.099 ms) : 0, 800099
AgentMeter [baseline] (11.417 ms) : 0, 11417
AgentMeter [candidate] (11.502 ms) : 0, 11502
GlobalTracer [baseline] (247.769 ms) : 0, 247769
GlobalTracer [candidate] (249.284 ms) : 0, 249284
IAST [baseline] (25.364 ms) : 0, 25364
IAST [candidate] (25.576 ms) : 0, 25576
AppSec [baseline] (27.377 ms) : 0, 27377
AppSec [candidate] (26.805 ms) : 0, 26805
Debugger [baseline] (70.063 ms) : 0, 70063
Debugger [candidate] (70.971 ms) : 0, 70971
Remote Config [baseline] (523.933 µs) : 0, 524
Remote Config [candidate] (525.204 µs) : 0, 525
Telemetry [baseline] (9.167 ms) : 0, 9167
Telemetry [candidate] (9.182 ms) : 0, 9182
Flare Poller [baseline] (3.318 ms) : 0, 3318
Flare Poller [candidate] (3.326 ms) : 0, 3326
section profiling
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.172 ms) : 0, 1172
BytebuddyAgent [baseline] (686.99 ms) : 0, 686990
BytebuddyAgent [candidate] (683.084 ms) : 0, 683084
AgentMeter [baseline] (9.046 ms) : 0, 9046
AgentMeter [candidate] (8.979 ms) : 0, 8979
GlobalTracer [baseline] (216.653 ms) : 0, 216653
GlobalTracer [candidate] (215.486 ms) : 0, 215486
AppSec [baseline] (32.52 ms) : 0, 32520
AppSec [candidate] (32.139 ms) : 0, 32139
Debugger [baseline] (65.422 ms) : 0, 65422
Debugger [candidate] (65.838 ms) : 0, 65838
Remote Config [baseline] (572.109 µs) : 0, 572
Remote Config [candidate] (557.191 µs) : 0, 557
Telemetry [baseline] (8.565 ms) : 0, 8565
Telemetry [candidate] (7.71 ms) : 0, 7710
Flare Poller [baseline] (3.518 ms) : 0, 3518
Flare Poller [candidate] (3.507 ms) : 0, 3507
ProfilingAgent [baseline] (94.187 ms) : 0, 94187
ProfilingAgent [candidate] (93.863 ms) : 0, 93863
Profiling [baseline] (94.764 ms) : 0, 94764
Profiling [candidate] (94.413 ms) : 0, 94413
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~d765eda60d, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1073998
Total [baseline] (8.87 s) : 0, 8870225
Agent [candidate] (1.055 s) : 0, 1054591
Total [candidate] (8.866 s) : 0, 8866268
section iast
Agent [baseline] (1.228 s) : 0, 1227919
Total [baseline] (9.559 s) : 0, 9558558
Agent [candidate] (1.238 s) : 0, 1237726
Total [candidate] (9.585 s) : 0, 9585127
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~d765eda60d, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (638.558 ms) : 0, 638558
BytebuddyAgent [candidate] (628.686 ms) : 0, 628686
AgentMeter [baseline] (29.991 ms) : 0, 29991
AgentMeter [candidate] (29.196 ms) : 0, 29196
GlobalTracer [baseline] (261.699 ms) : 0, 261699
GlobalTracer [candidate] (256.641 ms) : 0, 256641
AppSec [baseline] (32.527 ms) : 0, 32527
AppSec [candidate] (31.607 ms) : 0, 31607
Debugger [baseline] (60.57 ms) : 0, 60570
Debugger [candidate] (59.191 ms) : 0, 59191
Remote Config [baseline] (592.192 µs) : 0, 592
Remote Config [candidate] (597.293 µs) : 0, 597
Telemetry [baseline] (8.175 ms) : 0, 8175
Telemetry [candidate] (7.964 ms) : 0, 7964
Flare Poller [baseline] (4.365 ms) : 0, 4365
Flare Poller [candidate] (3.503 ms) : 0, 3503
section iast
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (796.911 ms) : 0, 796911
BytebuddyAgent [candidate] (803.321 ms) : 0, 803321
AgentMeter [baseline] (11.416 ms) : 0, 11416
AgentMeter [candidate] (11.644 ms) : 0, 11644
GlobalTracer [baseline] (247.325 ms) : 0, 247325
GlobalTracer [candidate] (249.025 ms) : 0, 249025
IAST [baseline] (25.397 ms) : 0, 25397
IAST [candidate] (25.543 ms) : 0, 25543
AppSec [baseline] (26.57 ms) : 0, 26570
AppSec [candidate] (26.826 ms) : 0, 26826
Debugger [baseline] (69.286 ms) : 0, 69286
Debugger [candidate] (70.063 ms) : 0, 70063
Remote Config [baseline] (531.53 µs) : 0, 532
Remote Config [candidate] (538.993 µs) : 0, 539
Telemetry [baseline] (9.692 ms) : 0, 9692
Telemetry [candidate] (9.744 ms) : 0, 9744
Flare Poller [baseline] (3.493 ms) : 0, 3493
Flare Poller [candidate] (3.541 ms) : 0, 3541
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~d765eda60d, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section baseline
no_agent (1.205 ms) : 1193, 1217
. : milestone, 1205,
iast (3.207 ms) : 3162, 3252
. : milestone, 3207,
iast_FULL (5.806 ms) : 5748, 5864
. : milestone, 5806,
iast_GLOBAL (3.643 ms) : 3577, 3710
. : milestone, 3643,
profiling (2.099 ms) : 2079, 2119
. : milestone, 2099,
tracing (1.749 ms) : 1735, 1762
. : milestone, 1749,
section candidate
no_agent (1.167 ms) : 1156, 1178
. : milestone, 1167,
iast (3.276 ms) : 3235, 3317
. : milestone, 3276,
iast_FULL (5.997 ms) : 5936, 6058
. : milestone, 5997,
iast_GLOBAL (3.356 ms) : 3313, 3399
. : milestone, 3356,
profiling (2.062 ms) : 2044, 2079
. : milestone, 2062,
tracing (1.771 ms) : 1757, 1785
. : milestone, 1771,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~d765eda60d, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section baseline
no_agent (18.167 ms) : 17977, 18358
. : milestone, 18167,
appsec (18.79 ms) : 18602, 18978
. : milestone, 18790,
code_origins (17.753 ms) : 17573, 17933
. : milestone, 17753,
iast (17.733 ms) : 17557, 17910
. : milestone, 17733,
profiling (18.48 ms) : 18297, 18662
. : milestone, 18480,
tracing (17.417 ms) : 17249, 17586
. : milestone, 17417,
section candidate
no_agent (18.341 ms) : 18154, 18527
. : milestone, 18341,
appsec (18.803 ms) : 18615, 18991
. : milestone, 18803,
code_origins (17.604 ms) : 17431, 17778
. : milestone, 17604,
iast (17.96 ms) : 17782, 18138
. : milestone, 17960,
profiling (18.379 ms) : 18198, 18559
. : milestone, 18379,
tracing (17.6 ms) : 17426, 17775
. : milestone, 17600,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~d765eda60d, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section baseline
no_agent (15.049 s) : 15049000, 15049000
. : milestone, 15049000,
appsec (14.629 s) : 14629000, 14629000
. : milestone, 14629000,
iast (17.988 s) : 17988000, 17988000
. : milestone, 17988000,
iast_GLOBAL (18.015 s) : 18015000, 18015000
. : milestone, 18015000,
profiling (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
tracing (15.0 s) : 15000000, 15000000
. : milestone, 15000000,
section candidate
no_agent (15.076 s) : 15076000, 15076000
. : milestone, 15076000,
appsec (14.627 s) : 14627000, 14627000
. : milestone, 14627000,
iast (18.23 s) : 18230000, 18230000
. : milestone, 18230000,
iast_GLOBAL (17.919 s) : 17919000, 17919000
. : milestone, 17919000,
profiling (15.498 s) : 15498000, 15498000
. : milestone, 15498000,
tracing (14.917 s) : 14917000, 14917000
. : milestone, 14917000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~d765eda60d, baseline=1.61.0-SNAPSHOT~126645d10a
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.809 ms) : 3586, 4033
. : milestone, 3809,
iast (2.241 ms) : 2172, 2310
. : milestone, 2241,
iast_GLOBAL (2.303 ms) : 2234, 2373
. : milestone, 2303,
profiling (2.075 ms) : 2021, 2129
. : milestone, 2075,
tracing (2.056 ms) : 2002, 2109
. : milestone, 2056,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.743 ms) : 3525, 3962
. : milestone, 3743,
iast (2.249 ms) : 2181, 2318
. : milestone, 2249,
iast_GLOBAL (2.3 ms) : 2230, 2369
. : milestone, 2300,
profiling (2.115 ms) : 2059, 2172
. : milestone, 2115,
tracing (2.074 ms) : 2020, 2128
. : milestone, 2074,
|
|
I think this is okay, but I just want to double check. If it impacts, resourceName then we might break metrics or sampling for someone. |
This is a breaking change so users should be adequately informed about |
Thanks, I want to dig in to see how many users have this pattern. |
Summary
queue:///MY.QUEUE) fromQueue.getQueueName()when destinations are created with URI syntax. This causesqueue:///-prefixed names to appear in DSM data.sanitizeUriPrefix()inJMSDecoratorto stripqueue://andtopic://prefixes (case-insensitive) plus any remaining leading/characters, applied before the existing TIBCO and Kafka Connect sanitizations so they compose correctly.Test plan
./gradlew :dd-java-agent:instrumentation:jms:javax-jms-1.1:test --tests "JMSDecoratorTest"passes🤖 Generated with Claude Code