Skip to content

Serialize min/max values from OTel histograms#11034

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
mcculls/add-min-max-to-otel-histograms
Apr 2, 2026
Merged

Serialize min/max values from OTel histograms#11034
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
mcculls/add-min-max-to-otel-histograms

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Apr 1, 2026

Motivation

These values are optional in metrics.proto but are expected in our current system tests.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@mcculls mcculls requested a review from a team as a code owner April 1, 2026 21:23
@mcculls mcculls added the tag: no release notes Changes to exclude from release notes label Apr 1, 2026
@mcculls mcculls requested review from mhlidd and removed request for a team April 1, 2026 21:23
@mcculls mcculls added the inst: opentelemetry OpenTelemetry instrumentation label Apr 1, 2026
@mcculls mcculls requested a review from bric3 April 2, 2026 08:27
@mcculls
Copy link
Copy Markdown
Contributor Author

mcculls commented Apr 2, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Apr 2, 2026

View all feedbacks in Devflow UI.

2026-04-02 08:37:25 UTC ℹ️ Start processing command /merge


2026-04-02 08:37:29 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-04-02 09:36:09 UTC ℹ️ MergeQueue: This merge request was merged

@PerfectSlayer
Copy link
Copy Markdown
Contributor

❔ question: ‏ I did review the PR but not approved it to let @mhlidd to step in.
Is that something you (@mcculls and the broader SDK team) is looking for or are you more focused on getting this kind of changes merged ASAP?

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 5741677 into master Apr 2, 2026
569 of 572 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the mcculls/add-min-max-to-otel-histograms branch April 2, 2026 09:36
@github-actions github-actions bot added this to the 1.61.0 milestone Apr 2, 2026
@mcculls
Copy link
Copy Markdown
Contributor Author

mcculls commented Apr 2, 2026

❔ question: ‏ I did review the PR but not approved it to let @mhlidd to step in.

This is generic enough that anyone on the Java team could review it - there's nothing specific to our team, and I'd prefer not to let PRs linger unnecessarily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: opentelemetry OpenTelemetry instrumentation tag: no release notes Changes to exclude from release notes type: feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants